Changeset 237591 in webkit

Timestamp:

Oct 30, 2018 10:32:05 AM (5 years ago)

Author:

sihui_liu@apple.com

Message:

Add a deprecation warning to console for Web SQL
​https://bugs.webkit.org/show_bug.cgi?id=190936

Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests. Just adding a console message.

• Modules/webdatabase/DOMWindowWebDatabase.cpp:

(WebCore::DOMWindowWebDatabase::openDatabase):

LayoutTests:

Rebaseline the tests that are affected by the added console message.

• fast/dom/MutationObserver/database-callback-delivery-expected.txt:
• fast/frames/sandboxed-iframe-storage-expected.txt:
• fast/history/page-cache-webdatabase-no-transaction-db-expected.txt:
• http/tests/security/cross-origin-websql-allowed-expected.txt:
• http/tests/security/cross-origin-websql-expected.txt:
• http/tests/security/same-origin-websql-blocked-expected.txt:
• http/tests/security/storage-blocking-loosened-websql-expected.txt:
• http/tests/security/storage-blocking-strengthened-websql-expected.txt:
• http/tests/storage/callbacks-are-called-in-correct-context-expected.txt:
• inspector/runtime/CommandLineAPI-inspect-expected.txt:
• js/dom/callback-function-with-handle-event-expected.txt:
• js/dom/exceptions-thrown-in-callbacks-expected.txt:
• storage/websql/alter-to-info-table-expected.txt:
• storage/websql/change-version-expected.txt:
• storage/websql/change-version-handle-reuse-expected.txt:
• storage/websql/change-version-no-crash-on-preflight-failure-expected.txt:
• storage/websql/close-during-stress-test-expected.txt:
• storage/websql/database-lock-after-reload-expected.txt:
• storage/websql/empty-statement-expected.txt:
• storage/websql/execute-sql-args-expected.txt:
• storage/websql/execute-sql-rowsAffected-expected.txt:
• storage/websql/executesql-accepts-only-one-statement-expected.txt:
• storage/websql/hash-change-with-xhr-expected.txt:
• storage/websql/multiple-databases-garbage-collection-expected.txt:
• storage/websql/multiple-transactions-expected.txt:
• storage/websql/multiple-transactions-on-different-handles-expected.txt:
• storage/websql/null-callbacks-expected.txt:
• storage/websql/open-database-creation-callback-expected.txt:
• storage/websql/open-database-creation-callback-isolated-world-expected.txt:
• storage/websql/open-database-empty-version-expected.txt:
• storage/websql/open-database-expand-quota-expected.txt:
• storage/websql/open-database-over-quota-expected.txt:
• storage/websql/open-database-set-empty-version-expected.txt:
• storage/websql/open-database-while-transaction-in-progress-expected.txt:
• storage/websql/private-browsing-noread-nowrite-expected.txt:
• storage/websql/read-and-write-transactions-dont-run-together-expected.txt:
• storage/websql/read-transactions-running-concurrently-expected.txt:
• storage/websql/sql-data-types-expected.txt:
• storage/websql/statement-error-callback-expected.txt:
• storage/websql/statement-error-callback-isolated-world-expected.txt:
• storage/websql/statement-success-callback-isolated-world-expected.txt:
• storage/websql/success-callback-expected.txt:
• storage/websql/success-callback-when-page-defers-loading-expected.txt:
• storage/websql/test-authorizer-expected.txt:
• storage/websql/transaction-callback-exception-crash-expected.txt:
• storage/websql/transaction-callback-isolated-world-expected.txt:
• storage/websql/transaction-database-expand-quota-expected.txt:
• storage/websql/transaction-error-callback-expected.txt:
• storage/websql/transaction-error-callback-isolated-world-expected.txt:
• storage/websql/transaction-prototype-expected.txt:
• storage/websql/transaction-success-callback-isolated-world-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/MutationObserver/database-callback-delivery-expected.txt (modified) (1 diff)
• LayoutTests/fast/frames/sandboxed-iframe-storage-expected.txt (modified) (1 diff)
• LayoutTests/fast/history/page-cache-webdatabase-no-transaction-db-expected.txt (modified) (1 diff)
• LayoutTests/http/tests/security/cross-origin-websql-allowed-expected.txt (modified) (1 diff)
• LayoutTests/http/tests/security/cross-origin-websql-expected.txt (modified) (1 diff)
• LayoutTests/http/tests/security/same-origin-websql-blocked-expected.txt (modified) (1 diff)
• LayoutTests/http/tests/security/storage-blocking-loosened-websql-expected.txt (modified) (1 diff)
• LayoutTests/http/tests/security/storage-blocking-strengthened-websql-expected.txt (modified) (1 diff)
• LayoutTests/http/tests/storage/callbacks-are-called-in-correct-context-expected.txt (modified) (1 diff)
• LayoutTests/inspector/runtime/CommandLineAPI-inspect-expected.txt (modified) (1 diff)
• LayoutTests/js/dom/callback-function-with-handle-event-expected.txt (modified) (1 diff)
• LayoutTests/js/dom/exceptions-thrown-in-callbacks-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/alter-to-info-table-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/change-version-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/change-version-handle-reuse-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/change-version-no-crash-on-preflight-failure-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/close-during-stress-test-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/database-lock-after-reload-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/empty-statement-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/execute-sql-args-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/execute-sql-rowsAffected-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/executesql-accepts-only-one-statement-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/hash-change-with-xhr-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/multiple-databases-garbage-collection-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/multiple-transactions-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/multiple-transactions-on-different-handles-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/null-callbacks-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/open-database-creation-callback-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/open-database-creation-callback-isolated-world-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/open-database-empty-version-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/open-database-expand-quota-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/open-database-over-quota-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/open-database-set-empty-version-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/open-database-while-transaction-in-progress-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/private-browsing-noread-nowrite-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/read-and-write-transactions-dont-run-together-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/read-transactions-running-concurrently-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/sql-data-types-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/statement-error-callback-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/statement-error-callback-isolated-world-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/statement-success-callback-isolated-world-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/success-callback-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/success-callback-when-page-defers-loading-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/test-authorizer-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/transaction-callback-exception-crash-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/transaction-callback-isolated-world-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/transaction-database-expand-quota-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/transaction-error-callback-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/transaction-error-callback-isolated-world-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/transaction-prototype-expected.txt (modified) (1 diff)
• LayoutTests/storage/websql/transaction-success-callback-isolated-world-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-10-30  Sihui Liu  <sihui_liu@apple.com>
+
+        Add a deprecation warning to console for Web SQL
+        https://bugs.webkit.org/show_bug.cgi?id=190936
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaseline the tests that are affected by the added console message.
+
+        * fast/dom/MutationObserver/database-callback-delivery-expected.txt:
+        * fast/frames/sandboxed-iframe-storage-expected.txt:
+        * fast/history/page-cache-webdatabase-no-transaction-db-expected.txt:
+        * http/tests/security/cross-origin-websql-allowed-expected.txt:
+        * http/tests/security/cross-origin-websql-expected.txt:
+        * http/tests/security/same-origin-websql-blocked-expected.txt:
+        * http/tests/security/storage-blocking-loosened-websql-expected.txt:
+        * http/tests/security/storage-blocking-strengthened-websql-expected.txt:
+        * http/tests/storage/callbacks-are-called-in-correct-context-expected.txt:
+        * inspector/runtime/CommandLineAPI-inspect-expected.txt:
+        * js/dom/callback-function-with-handle-event-expected.txt:
+        * js/dom/exceptions-thrown-in-callbacks-expected.txt:
+        * storage/websql/alter-to-info-table-expected.txt:
+        * storage/websql/change-version-expected.txt:
+        * storage/websql/change-version-handle-reuse-expected.txt:
+        * storage/websql/change-version-no-crash-on-preflight-failure-expected.txt:
+        * storage/websql/close-during-stress-test-expected.txt:
+        * storage/websql/database-lock-after-reload-expected.txt:
+        * storage/websql/empty-statement-expected.txt:
+        * storage/websql/execute-sql-args-expected.txt:
+        * storage/websql/execute-sql-rowsAffected-expected.txt:
+        * storage/websql/executesql-accepts-only-one-statement-expected.txt:
+        * storage/websql/hash-change-with-xhr-expected.txt:
+        * storage/websql/multiple-databases-garbage-collection-expected.txt:
+        * storage/websql/multiple-transactions-expected.txt:
+        * storage/websql/multiple-transactions-on-different-handles-expected.txt:
+        * storage/websql/null-callbacks-expected.txt:
+        * storage/websql/open-database-creation-callback-expected.txt:
+        * storage/websql/open-database-creation-callback-isolated-world-expected.txt:
+        * storage/websql/open-database-empty-version-expected.txt:
+        * storage/websql/open-database-expand-quota-expected.txt:
+        * storage/websql/open-database-over-quota-expected.txt:
+        * storage/websql/open-database-set-empty-version-expected.txt:
+        * storage/websql/open-database-while-transaction-in-progress-expected.txt:
+        * storage/websql/private-browsing-noread-nowrite-expected.txt:
+        * storage/websql/read-and-write-transactions-dont-run-together-expected.txt:
+        * storage/websql/read-transactions-running-concurrently-expected.txt:
+        * storage/websql/sql-data-types-expected.txt:
+        * storage/websql/statement-error-callback-expected.txt:
+        * storage/websql/statement-error-callback-isolated-world-expected.txt:
+        * storage/websql/statement-success-callback-isolated-world-expected.txt:
+        * storage/websql/success-callback-expected.txt:
+        * storage/websql/success-callback-when-page-defers-loading-expected.txt:
+        * storage/websql/test-authorizer-expected.txt:
+        * storage/websql/transaction-callback-exception-crash-expected.txt:
+        * storage/websql/transaction-callback-isolated-world-expected.txt:
+        * storage/websql/transaction-database-expand-quota-expected.txt:
+        * storage/websql/transaction-error-callback-expected.txt:
+        * storage/websql/transaction-error-callback-isolated-world-expected.txt:
+        * storage/websql/transaction-prototype-expected.txt:
+        * storage/websql/transaction-success-callback-isolated-world-expected.txt:
+
 2018-10-30  Sihui Liu  <sihui_liu@apple.com>
 

trunk/LayoutTests/fast/dom/MutationObserver/database-callback-delivery-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 21: Web SQL is deprecated. Please use IndexedDB instead.
 Testing mutations are delivered following Database transaction callbacks.
 

trunk/LayoutTests/fast/frames/sandboxed-iframe-storage-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 1: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 1: Web SQL is deprecated. Please use IndexedDB instead.
 This test verifies that a sandboxed iframe does not have access to any session storage, local storage or database.
 

trunk/LayoutTests/fast/history/page-cache-webdatabase-no-transaction-db-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 32: Web SQL is deprecated. Please use IndexedDB instead.
 Tests that a page with an open WebDatabase with no pending transaction goes into the page cache.
 

trunk/LayoutTests/http/tests/security/cross-origin-websql-allowed-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead.
 This iframe should not return any errors:
 

trunk/LayoutTests/http/tests/security/cross-origin-websql-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead.
 This iframe should return a security error:
 

trunk/LayoutTests/http/tests/security/same-origin-websql-blocked-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead.
 This iframe should return a security error:
 

trunk/LayoutTests/http/tests/security/storage-blocking-loosened-websql-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 12: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 22: Web SQL is deprecated. Please use IndexedDB instead.
 This iframe should return only one security error:
 

trunk/LayoutTests/http/tests/security/storage-blocking-strengthened-websql-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 12: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 22: Web SQL is deprecated. Please use IndexedDB instead.
 This iframe should return only one security error:
 

trunk/LayoutTests/http/tests/storage/callbacks-are-called-in-correct-context-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 4: Web SQL is deprecated. Please use IndexedDB instead.
 
 

trunk/LayoutTests/inspector/runtime/CommandLineAPI-inspect-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 1: Web SQL is deprecated. Please use IndexedDB instead.
 Tests for CommandLineAPI.prototype.inspect with different object types.
 

trunk/LayoutTests/js/dom/callback-function-with-handle-event-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 32: Web SQL is deprecated. Please use IndexedDB instead.
 When a JS callback is a function, it should be called. If the function has another function as its handleEvent property, that function should not be called.
 

trunk/LayoutTests/js/dom/exceptions-thrown-in-callbacks-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 CONSOLE MESSAGE: line 17: PASS: toString called on exception value thrown from event handler
 CONSOLE MESSAGE: line 23: PASS: toString called on exception value thrown from sql transaction callback

trunk/LayoutTests/storage/websql/alter-to-info-table-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 This tests that a tricky way to setup your own info table fails.
 CREATE TABLE statement succeeded.

trunk/LayoutTests/storage/websql/change-version-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 63: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 64: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 86: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 45: Web SQL is deprecated. Please use IndexedDB instead.
 This test verifies that the JS database.changeVersion() function works as expected.
 Finished tests with version 3; expected version: 3

trunk/LayoutTests/storage/websql/change-version-handle-reuse-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 This tests that a database can be accessed after changing its version. You should see an error about FooBar table below, not about mismatching versions.
 changeVersion: transaction callback

trunk/LayoutTests/storage/websql/change-version-no-crash-on-preflight-failure-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 21: Web SQL is deprecated. Please use IndexedDB instead.
 This test verifies that no assertion is triggered when changeVersion()'s preflight step fails.
 PASS: db.changeVersion() failed as expected, and no assertions were triggered.

trunk/LayoutTests/storage/websql/close-during-stress-test-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 9: Web SQL is deprecated. Please use IndexedDB instead.
 Should not crash or cause an assertion failure.
 

trunk/LayoutTests/storage/websql/database-lock-after-reload-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 46: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 39: Web SQL is deprecated. Please use IndexedDB instead.
 Inserting some data
 Test part 2 Complete

trunk/LayoutTests/storage/websql/empty-statement-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 25: Web SQL is deprecated. Please use IndexedDB instead.
 Executed an empty statement. If you didn't see a crash or assertion, the test passed.
 

trunk/LayoutTests/storage/websql/execute-sql-args-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 PASS. executeSql(null) did not throw an exception
 PASS. executeSql(undefined) did not throw an exception

trunk/LayoutTests/storage/websql/execute-sql-rowsAffected-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 25: Web SQL is deprecated. Please use IndexedDB instead.
 This test tests that SQLResultSet.rowsAffected attribute is correct in success callback for executeSql().
 

trunk/LayoutTests/storage/websql/executesql-accepts-only-one-statement-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 54: Web SQL is deprecated. Please use IndexedDB instead.
 This test tests that executeSql() fails when called with a string that has more than one valid statement in it.
 Test passed.

trunk/LayoutTests/storage/websql/hash-change-with-xhr-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 Changing the hash to create history entries.
 Db is warmed up

trunk/LayoutTests/storage/websql/multiple-databases-garbage-collection-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 This test opens two databases, queues up a series of operations on both, then "forgets" about one of them. After forcing GC, resources associated with that database should be freed gracefully.
 Forgotten Database Transaction Complete

trunk/LayoutTests/storage/websql/multiple-transactions-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 This is a test to see if the database API allows multiple transactions to be queued on the same database at once:
 Transaction 1 Started

trunk/LayoutTests/storage/websql/multiple-transactions-on-different-handles-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 This is a test to see if queueing up multiple transactions on different handles to the same database results in a deadlock.
 db1 read statement succeeded

trunk/LayoutTests/storage/websql/null-callbacks-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 19: Web SQL is deprecated. Please use IndexedDB instead.
 This test checks that 'null' can be used wherever we expect an optional callback.
 PASS

trunk/LayoutTests/storage/websql/open-database-creation-callback-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 30: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 56: Web SQL is deprecated. Please use IndexedDB instead.
 CONSOLE MESSAGE: line 56: unable to open database, version mismatch, '1.0' does not match the currentVersion of ''
+CONSOLE MESSAGE: line 69: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 70: Web SQL is deprecated. Please use IndexedDB instead.
 This test tests openDatabase()'s creation callback.
 

trunk/LayoutTests/storage/websql/open-database-creation-callback-isolated-world-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 42: Web SQL is deprecated. Please use IndexedDB instead.
 ALERT: undefined
 ALERT: PASS: document.body.bar visible in a callback created in this world.

trunk/LayoutTests/storage/websql/open-database-empty-version-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 9: Web SQL is deprecated. Please use IndexedDB instead.
 This tests that calling openDatabase with an empty version string does not cause an exception to be thrown.
 SUCCESS! Did not throw an exception.

trunk/LayoutTests/storage/websql/open-database-expand-quota-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 13: Web SQL is deprecated. Please use IndexedDB instead.
 UI DELEGATE DATABASE CALLBACK: increased quota to 8000000
 This tests that calling openDatabase with a size over 5MB doesn't assert on debug builds, and will increase the quota to accommodate the requested size whennot exceeding a max limit of 10M.

trunk/LayoutTests/storage/websql/open-database-over-quota-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 11: Web SQL is deprecated. Please use IndexedDB instead.
 This tests that calling openDatabase with a size greater or equal to the test max quota limit of 5MB doesn't assert on debug builds.
 PASS

trunk/LayoutTests/storage/websql/open-database-set-empty-version-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 11: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 13: Web SQL is deprecated. Please use IndexedDB instead.
 CONSOLE MESSAGE: line 13: unable to open database, version mismatch, 'test' does not match the currentVersion of ''
 This tests that calling openDatabase with an empty version string sets the current version of that database to the empty string and subsequent attempts to open the database with a different expected version throw an exception.

trunk/LayoutTests/storage/websql/open-database-while-transaction-in-progress-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 This is a test to see if opening a database while a transaction is running on a different handle to the same database results in a deadlock.
 openDatabase() succeeded.

trunk/LayoutTests/storage/websql/private-browsing-noread-nowrite-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 92: Web SQL is deprecated. Please use IndexedDB instead.
 This test makes sure that attempts to change the database during private browsing fail.
 Setup statement 1 completed successfully

trunk/LayoutTests/storage/websql/read-and-write-transactions-dont-run-together-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 This test tests that read and write transactions on different handles to the same database don't run together.
 Transaction successful.

trunk/LayoutTests/storage/websql/read-transactions-running-concurrently-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 18: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 18: Web SQL is deprecated. Please use IndexedDB instead.
 This test tests that two read-only transactions on different handles to the same database run concurrently.
 Read transactions running concurrently.

trunk/LayoutTests/storage/websql/sql-data-types-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 82: Web SQL is deprecated. Please use IndexedDB instead.
 PASS: property 'timestamp' ok, type was number
 PASS: property 'id' ok, type was number

trunk/LayoutTests/storage/websql/statement-error-callback-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 64: Web SQL is deprecated. Please use IndexedDB instead.
 CONSOLE MESSAGE: line 67: Exception in statement error callback
 This test confirms that a transaction is immediately rolled back if and only if a statement's error callback throws an exception, returns true, or doesn't return any value.

trunk/LayoutTests/storage/websql/statement-error-callback-isolated-world-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 45: Web SQL is deprecated. Please use IndexedDB instead.
 ALERT: undefined
 ALERT: PASS: document.body.bar visible in a callback created in this world.

trunk/LayoutTests/storage/websql/statement-success-callback-isolated-world-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 45: Web SQL is deprecated. Please use IndexedDB instead.
 ALERT: undefined
 ALERT: PASS: document.body.bar visible in a callback created in this world.

trunk/LayoutTests/storage/websql/success-callback-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 40: Web SQL is deprecated. Please use IndexedDB instead.
 This test confirms that a successful transaction - both with and without a statement - receives its successCallback
 Transaction succeeded - Transaction with one statement

trunk/LayoutTests/storage/websql/success-callback-when-page-defers-loading-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 18: Web SQL is deprecated. Please use IndexedDB instead.
 This tests that a SQL success callback completes when the page defers loading.
 

trunk/LayoutTests/storage/websql/test-authorizer-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 8: Web SQL is deprecated. Please use IndexedDB instead.
 This test tests the database authorizer.
 SQLITE_CREATE_TABLE statement succeeded.

trunk/LayoutTests/storage/websql/transaction-callback-exception-crash-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 9: Web SQL is deprecated. Please use IndexedDB instead.
 CONSOLE MESSAGE: line 13: TransactionCallbackError
 If WebKit doesn't crash, this test has passed

trunk/LayoutTests/storage/websql/transaction-callback-isolated-world-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 43: Web SQL is deprecated. Please use IndexedDB instead.
 ALERT: undefined
 ALERT: PASS: document.body.bar visible in a callback created in this world.

trunk/LayoutTests/storage/websql/transaction-database-expand-quota-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 48: Web SQL is deprecated. Please use IndexedDB instead.
 UI DELEGATE DATABASE CALLBACK: exceededDatabaseQuotaForSecurityOrigin:{file, , 0} database:ExpandedQuotaTransaction
 UI DELEGATE DATABASE CALLBACK: increased quota to 209715

trunk/LayoutTests/storage/websql/transaction-error-callback-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 76: Web SQL is deprecated. Please use IndexedDB instead.
 CONSOLE MESSAGE: line 63: [object Object]
 CONSOLE MESSAGE: line 63: [object Object]

trunk/LayoutTests/storage/websql/transaction-error-callback-isolated-world-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 45: Web SQL is deprecated. Please use IndexedDB instead.
 ALERT: undefined
 ALERT: PASS: document.body.bar visible in a callback created in this world.

trunk/LayoutTests/storage/websql/transaction-prototype-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 9: Web SQL is deprecated. Please use IndexedDB instead.
 Tests that it is possible to access SQLTransaction.constructor.prototype and that it is correct
 

trunk/LayoutTests/storage/websql/transaction-success-callback-isolated-world-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 6: Web SQL is deprecated. Please use IndexedDB instead.
+CONSOLE MESSAGE: line 43: Web SQL is deprecated. Please use IndexedDB instead.
 ALERT: undefined
 ALERT: PASS: document.body.bar visible in a callback created in this world.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-10-30  Sihui Liu  <sihui_liu@apple.com>
+
+        Add a deprecation warning to console for Web SQL
+        https://bugs.webkit.org/show_bug.cgi?id=190936
+
+        Reviewed by Ryosuke Niwa.
+
+        No new tests. Just adding a console message.
+
+        * Modules/webdatabase/DOMWindowWebDatabase.cpp:
+        (WebCore::DOMWindowWebDatabase::openDatabase):
+
 2018-10-30  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp

@@ -46 +46 @@
     if (!document)
         return Exception { SecurityError };
+    document->addConsoleMessage(MessageSource::Storage, MessageLevel::Warning, "Web SQL is deprecated. Please use IndexedDB instead.");
+
     auto& securityOrigin = document->securityOrigin();
     if (!securityOrigin.canAccessDatabase(document->topOrigin()))