Changeset 237793 in webkit

Timestamp:

Nov 5, 2018 1:34:01 AM (5 years ago)

Author:

Fujii Hironori

Message:

[Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot have a storage class"
​https://bugs.webkit.org/show_bug.cgi?id=191146

Reviewed by Yusuke Suzuki.

• jit/JIT.h: Changed is64BitType from a template class method to a

template inner class.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/JIT.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-11-05  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot have a storage class"
+        https://bugs.webkit.org/show_bug.cgi?id=191146
+
+        Reviewed by Yusuke Suzuki.
+
+        * jit/JIT.h: Changed is64BitType from a template class method to a
+        template inner class.
+
 2018-11-02  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/jit/JIT.h

@@ -782 +782 @@
 
         template<typename Type>
-        static constexpr bool is64BitType() { return sizeof(Type) <= 8; }
+        struct is64BitType {
+            static constexpr bool value = sizeof(Type) <= 8;
+        };
 
         template<>
-        static constexpr bool is64BitType<void>() { return true; }
+        struct is64BitType<void> {
+            static constexpr bool value = true;
+        };
 
         template<typename OperationType, typename... Args>
@@ -791 +795 @@
         callOperation(OperationType operation, Args... args)
         {
-            static_assert(is64BitType<typename FunctionTraits<OperationType>::ResultType>(), "Win64 cannot use standard call when return type is larger than 64 bits.");
+            static_assert(is64BitType<typename FunctionTraits<OperationType>::ResultType>::value, "Win64 cannot use standard call when return type is larger than 64 bits.");
             setupArguments<OperationType>(args...);
             return appendCallWithExceptionCheck(operation);