Changeset 237798 in webkit


Ignore:
Timestamp:
Nov 5, 2018 6:47:40 AM (5 years ago)
Author:
ajuma@chromium.org
Message:

[IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
​https://bugs.webkit.org/show_bug.cgi?id=191210

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectation for test that now passes.

  • web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.txt:

Source/WebCore:

isIntersecting should be false if the intersection ratio is smaller than the
smallest threshold value. Update the computation of isIntersecting to depend on
the current thresholdIndex.

Test: imported/w3c/web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.html

  • dom/Document.cpp:

(WebCore::Document::updateIntersectionObservations):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r237779 r237798  
     12018-11-05  Ali Juma  <ajuma@chromium.org>
     2
     3        [IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
     4        https://bugs.webkit.org/show_bug.cgi?id=191210
     5
     6        Reviewed by Simon Fraser.
     7
     8        Update expectation for test that now passes.
     9
     10        * web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.txt:
     11
    1122018-11-04  Youenn Fablet  <youenn@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.txt

    r235923 r237798  
    11
    22PASS First observation with a threshold.
    3 FAIL First rAF assert_equals: entries[0].isIntersecting expected false but got true
     3PASS First rAF
    44PASS root.scrollTop = 20
    55

  • trunk/Source/WebCore/ChangeLog

    r237797 r237798  
     12018-11-05  Ali Juma  <ajuma@chromium.org>
     2
     3        [IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
     4        https://bugs.webkit.org/show_bug.cgi?id=191210
     5
     6        Reviewed by Simon Fraser.
     7
     8        isIntersecting should be false if the intersection ratio is smaller than the
     9        smallest threshold value. Update the computation of isIntersecting to depend on
     10        the current thresholdIndex.
     11
     12        Test: imported/w3c/web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.html
     13
     14        * dom/Document.cpp:
     15        (WebCore::Document::updateIntersectionObservations):
     16
    1172018-11-05  Rob Buis  <rbuis@igalia.com>
    218

  • trunk/Source/WebCore/dom/Document.cpp

    r237785 r237798  
    77797779                    intersectionRatio,
    77807780                    target,
    7781                     intersectionState? intersectionState->isIntersecting : false,
     7781                    thresholdIndex > 0,
    77827782                }));
    77837783                needNotify = true;
Note: See TracChangeset for help on using the changeset viewer.