Changeset 237946 in webkit

Timestamp:

Nov 7, 2018 3:02:37 PM (5 years ago)

Author:

Simon Fraser

Message:

Revert 237849: it breaks MotionMark
​https://bugs.webkit.org/show_bug.cgi?id=191398

Reviewed by Simon Fraser.

Source/WebCore:

This change broke painting while the test is running.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):

LayoutTests:

• fast/scrolling/ios/update-scroll-coordinated-status-expected.txt: Removed.
• fast/scrolling/ios/update-scroll-coordinated-status.html: Removed.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/ios/update-scroll-coordinated-status-expected.txt (deleted)
• LayoutTests/fast/scrolling/ios/update-scroll-coordinated-status.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-11-07  Simon Fraser  <simon.fraser@apple.com>
+
+        Revert 237849: it breaks MotionMark
+        https://bugs.webkit.org/show_bug.cgi?id=191398
+
+        Reviewed by Simon Fraser.
+
+        * fast/scrolling/ios/update-scroll-coordinated-status-expected.txt: Removed.
+        * fast/scrolling/ios/update-scroll-coordinated-status.html: Removed.
+
 2018-11-07  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-11-07  Simon Fraser  <simon.fraser@apple.com>
+
+        Revert 237849: it breaks MotionMark
+        https://bugs.webkit.org/show_bug.cgi?id=191398
+
+        Reviewed by Simon Fraser.
+
+        This change broke painting while the test is running.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
+
 2018-11-07  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -3545 +3545 @@
         layer.backing()->setIsScrollCoordinatedWithViewportConstrainedRole(coordinationRoles.contains(ViewportConstrained));
 
-    if (layer.backing() && layer.backing()->updateConfiguration())
-        setCompositingLayersNeedRebuild();
-
     if (coordinationRoles && canCoordinateScrollingForLayer(layer)) {
         if (m_scrollCoordinatedLayers.add(&layer).isNewEntry)