Changeset 238016 in webkit

Timestamp:

Nov 8, 2018 9:30:48 PM (5 years ago)

Author:

Ross Kirsling

Message:

[JSC] isStrWhiteSpace seems redundant with Lexer<UChar>::isWhiteSpace
​https://bugs.webkit.org/show_bug.cgi?id=191439

Reviewed by Saam Barati.

• CMakeLists.txt:
• runtime/ParseInt.h:

(JSC::isStrWhiteSpace):
Define isStrWhiteSpace in terms of isWhiteSpace and isLineTerminator.

Location:

trunk/Source/JavaScriptCore

Files:

• CMakeLists.txt (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• runtime/ParseInt.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/CMakeLists.txt

@@ -693 +693 @@
     llint/LLIntOpcode.h
 
+    parser/Lexer.h
+    parser/ParserArena.h
     parser/ParserError.h
     parser/ParserModes.h

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-11-08  Ross Kirsling  <ross.kirsling@sony.com>
+
+        [JSC] isStrWhiteSpace seems redundant with Lexer<UChar>::isWhiteSpace
+        https://bugs.webkit.org/show_bug.cgi?id=191439
+
+        Reviewed by Saam Barati.
+
+        * CMakeLists.txt:
+        * runtime/ParseInt.h:
+        (JSC::isStrWhiteSpace):
+        Define isStrWhiteSpace in terms of isWhiteSpace and isLineTerminator.
+
 2018-11-08  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/JavaScriptCore/runtime/ParseInt.h

@@ -27 +27 @@
 
 #include "JSCJSValue.h"
+#include "Lexer.h"
 #include <wtf/dtoa.h>
 
@@ -102 +103 @@
 ALWAYS_INLINE static bool isStrWhiteSpace(UChar c)
 {
-    switch (c) {
-    // ECMA-262-5th 7.2 & 7.3
-    case 0x0009:
-    case 0x000A:
-    case 0x000B:
-    case 0x000C:
-    case 0x000D:
-    case 0x0020:
-    case 0x00A0:
-    case 0x2028:
-    case 0x2029:
-    case 0xFEFF:
-        return true;
-    default:
-        return c > 0xFF && u_charType(c) == U_SPACE_SEPARATOR;
-    }
+    // https://tc39.github.io/ecma262/#sec-tonumber-applied-to-the-string-type
+    return Lexer<UChar>::isWhiteSpace(c) || Lexer<UChar>::isLineTerminator(c);
 }