Changeset 238125 in webkit


Ignore:
Timestamp:
Nov 12, 2018 11:41:30 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Implement Cache API support for WPE/GTK
​https://bugs.webkit.org/show_bug.cgi?id=178316

Patch by Darshan Kadu <​darsh7807@gmail.com> on 2018-11-12
Reviewed by Michael Catanzaro.

Source/WebKit:

Added a new API function WKWebsiteDataStoreSetCacheStoragePerOriginQuota which sets the
cache limit per origin.

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetCacheStoragePerOriginQuota):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:

Tools:

Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::generatePageConfiguration):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):

LayoutTests:

Removed the http/wpt/cache-storage/cache-quota.any.html from the TestExpectations which
were marked faliure.

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r238122 r238125  
     12018-11-12  Darshan Kadu  <darsh7807@gmail.com>
     2
     3        Implement Cache API support for WPE/GTK
     4        https://bugs.webkit.org/show_bug.cgi?id=178316
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Removed the http/wpt/cache-storage/cache-quota.any.html from the TestExpectations which
     9        were marked faliure.
     10
     11        * platform/gtk/TestExpectations:
     12        * platform/wpe/TestExpectations:
     13
    1142018-11-12  Devin Rousso  <drousso@apple.com>
    215

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r238122 r238125  
    11181118fast/forms/range/input-appearance-range-rtl.html [ ImageOnlyFailure ]
    11191119
    1120 # Cache storage
    1121 webkit.org/b/178316 http/wpt/cache-storage/cache-quota.any.html [ Failure ]
    1122 
    11231120# Service-workers tests that fail, time out or crash.
    11241121webkit.org/b/175419 http/tests/workers/service/controller-change.html [ Skip ]

  • trunk/LayoutTests/platform/wpe/TestExpectations

    r238122 r238125  
    493493http/tests/websocket [ Skip ]
    494494http/tests/xmlhttprequest [ Skip ]
    495 
    496 # Cache storage
    497 webkit.org/b/178316 http/wpt/cache-storage/cache-quota.any.html [ Skip ]
    498495
    499496# Service-workers tests that fail, time out or crash.

  • trunk/Source/WebKit/ChangeLog

    r238115 r238125  
     12018-11-12  Darshan Kadu  <darsh7807@gmail.com>
     2
     3        Implement Cache API support for WPE/GTK
     4        https://bugs.webkit.org/show_bug.cgi?id=178316
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Added a new API function WKWebsiteDataStoreSetCacheStoragePerOriginQuota which sets the
     9        cache limit per origin.
     10
     11        * UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
     12        (WKWebsiteDataStoreSetCacheStoragePerOriginQuota):
     13        * UIProcess/API/C/WKWebsiteDataStoreRef.h:
     14
    1152018-11-12  Alex Christensen  <achristensen@webkit.org>
    216

  • trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp

    r236842 r238125  
    572572}
    573573
     574void WKWebsiteDataStoreSetCacheStoragePerOriginQuota(WKWebsiteDataStoreRef dataStoreRef, uint64_t quota)
     575{
     576    WebKit::toImpl(dataStoreRef)->websiteDataStore().setCacheStoragePerOriginQuota(quota);
     577}
    574578
    575579void WKWebsiteDataStoreSetWebAuthenticationMockConfiguration(WKWebsiteDataStoreRef dataStoreRef, WKDictionaryRef configurationRef)

  • trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h

    r236481 r238125  
    115115WK_EXPORT void WKWebsiteDataStoreSetServiceWorkerRegistrationDirectory(WKWebsiteDataStoreRef dataStoreRef, WKStringRef serviceWorkerRegistrationDirectory);
    116116
     117WK_EXPORT void WKWebsiteDataStoreSetCacheStoragePerOriginQuota(WKWebsiteDataStoreRef dataStoreRef, uint64_t quota);
     118
    117119WK_EXPORT void WKWebsiteDataStoreSetWebAuthenticationMockConfiguration(WKWebsiteDataStoreRef dataStoreRef, WKDictionaryRef configuration);
    118120

  • trunk/Tools/ChangeLog

    r238123 r238125  
     12018-11-12  Darshan Kadu  <darsh7807@gmail.com>
     2
     3        Implement Cache API support for WPE/GTK
     4        https://bugs.webkit.org/show_bug.cgi?id=178316
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
     9        on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
     10
     11        * WebKitTestRunner/TestController.cpp:
     12        (WTR::TestController::generatePageConfiguration):
     13        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
     14        (WTR::initializeWebViewConfiguration):
     15
    1162018-11-12  Christopher Reid  <chris.reid@sony.com>
    217

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r238108 r238125  
    484484    WKContextSetCacheModel(m_context.get(), kWKCacheModelDocumentBrowser);
    485485
     486    auto* websiteDataStore = WKContextGetWebsiteDataStore(m_context.get());
     487    WKWebsiteDataStoreSetCacheStoragePerOriginQuota(websiteDataStore, 400 * 1024);
     488   
    486489    platformInitializeContext();
    487490

  • trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

    r238108 r238125  
    7070
    7171    WKWebsiteDataStore* poolWebsiteDataStore = (__bridge WKWebsiteDataStore *)WKContextGetWebsiteDataStore((__bridge WKContextRef)globalWebViewConfiguration.processPool);
    72     [poolWebsiteDataStore _setCacheStoragePerOriginQuota: 400 * 1024];
    7372    if (libraryPath) {
    7473        String cacheStorageDirectory = String(libraryPath) + '/' + "CacheStorage";
Note: See TracChangeset for help on using the changeset viewer.