Changeset 238142 in webkit

Timestamp:

Nov 13, 2018 1:04:45 PM (5 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r238137.

Introduced API test failures on macOS.

Reverted changeset:

"Enable process swap on cross-site navigation by default on
macOS"
​https://bugs.webkit.org/show_bug.cgi?id=191572
​https://trac.webkit.org/changeset/238137

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebPreferences.yaml (modified) (1 diff)
• Shared/WebPreferencesDefaultValues.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-11-13  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r238137.
+
+        Introduced API test failures on macOS.
+
+        Reverted changeset:
+
+        "Enable process swap on cross-site navigation by default on
+        macOS"
+        https://bugs.webkit.org/show_bug.cgi?id=191572
+        https://trac.webkit.org/changeset/238137
+
 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebKit/Shared/WebPreferences.yaml

@@ -1350 +1350 @@
 ProcessSwapOnCrossSiteNavigationEnabled:
   type: bool
-  defaultValue: DEFAULT_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION_ENABLED
+  defaultValue: false
   humanReadableName: "Swap Processes on Cross-Site Navigation"
   humanReadableDescription: "Swap WebContent processes on cross-site navigations"

trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h

@@ -209 +209 @@
 #endif
 
-#if PLATFORM(MAC)
-#define DEFAULT_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION_ENABLED true
-#else
-#define DEFAULT_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION_ENABLED false
-#endif
-
 #if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(WATCHOS)
 #define DEFAULT_CONIC_GRADIENT_ENABLED true