Changeset 238158 in webkit

Timestamp:

Nov 13, 2018 7:48:53 PM (5 years ago)

Author:

Chris Dumez

Message:

WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
​https://bugs.webkit.org/show_bug.cgi?id=191618

Reviewed by Ryosuke Niwa.

Update API test to explicitly disable automatic process prewarning since it is testing
manual prewarming.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:

(TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-11-13  Chris Dumez  <cdumez@apple.com>
+
+        WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
+        https://bugs.webkit.org/show_bug.cgi?id=191618
+
+        Reviewed by Ryosuke Niwa.
+
+        Update API test to explicitly disable automatic process prewarning since it is testing
+        manual prewarming.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
+        (TEST):
+
 2018-11-13  Chris Dumez  <cdumez@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm

@@ -54 +54 @@
 TEST(WKProcessPool, InitialWarmedProcessUsed)
 {
-    auto pool = adoptNS([[WKProcessPool alloc] init]);
+    auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
+    processPoolConfiguration.get().prewarmsProcessesAutomatically = NO;
+
+    auto pool = adoptNS([[WKProcessPool alloc] _initWithConfiguration:processPoolConfiguration.get()]);
     [pool _warmInitialProcess];