Changeset 238169 in webkit
- Timestamp:
- Nov 14, 2018 4:01:31 AM (5 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r238168 r238169 1 2018-11-14 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: Canvas: don't start with auto-capture enabled 4 https://bugs.webkit.org/show_bug.cgi?id=191553 5 6 Reviewed by Matt Baker. 7 8 * UserInterface/Views/CanvasOverviewContentView.js: 9 (WI.CanvasOverviewContentView.prototype._setRecordingAutoCaptureFrameCount): 10 (WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize): 11 (WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureInput): 12 * UserInterface/Views/CanvasOverviewContentView.css: 13 (.navigation-bar > .item.canvas-recording-auto-capture > label > input): 14 1 15 2018-11-14 Devin Rousso <drousso@apple.com> 2 16 -
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css
r237670 r238169 182 182 width: 1.5em; 183 183 min-width: 1.5em; 184 margin: 0 4px;184 margin: 0 var(--recording-auto-capture-input-margin); 185 185 text-align: center; 186 187 --recording-auto-capture-input-margin: 4px; /* Keep this in sync with `recordingAutoCaptureInputMargin`. */ 186 188 } 187 189 -
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js
r237670 r238169 203 203 console.assert(!isNaN(frameCount) && frameCount >= 0); 204 204 205 let enabled = frameCount && !!this._recordingAutoCaptureNavigationItem.checked; 205 if (this._recordingAutoCaptureNavigationItem.checked) 206 frameCount = Math.max(1, frameCount); 207 208 let enabled = frameCount > 0 && !!this._recordingAutoCaptureNavigationItem.checked; 206 209 207 210 WI.canvasManager.setRecordingAutoCaptureFrameCount(enabled, frameCount); … … 222 225 } 223 226 227 const recordingAutoCaptureInputMargin = 8; // Keep this in sync with `--recording-auto-capture-input-margin`. 228 224 229 context.font = this._recordingAutoCaptureFrameCountInputElement.__cachedFont; 225 230 let textMetrics = context.measureText(this._recordingAutoCaptureFrameCountInputElement.value); 226 this._recordingAutoCaptureFrameCountInputElement.style.setProperty("width", (textMetrics.width + 8) + "px");231 this._recordingAutoCaptureFrameCountInputElement.style.setProperty("width", (textMetrics.width + recordingAutoCaptureInputMargin) + "px"); 227 232 }); 228 233 234 return frameCount; 235 } 236 237 _handleRecordingAutoCaptureInput(event) 238 { 239 let frameCount = this._updateRecordingAutoCaptureInputElementSize(); 229 240 this._recordingAutoCaptureNavigationItem.checked = !!frameCount; 230 } 231 232 _handleRecordingAutoCaptureInput(event) 233 { 234 this._updateRecordingAutoCaptureInputElementSize(); 241 235 242 this._setRecordingAutoCaptureFrameCount(); 236 243 }
Note: See TracChangeset
for help on using the changeset viewer.