Changeset 238242 in webkit


Ignore:
Timestamp:
Nov 15, 2018 12:40:42 PM (5 years ago)
Author:
Truitt Savell
Message:

Unreviewed, rolling out r238220.

Introduced failing tests to iOS and is slowing down EWS

Reverted changeset:

"[css-grid] Consider scrollbars in
populateGridPositionsForDirection()"
​https://bugs.webkit.org/show_bug.cgi?id=191656
​https://trac.webkit.org/changeset/238220

Location:
trunk
Files:
6 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r238230 r238242  
     12018-11-15  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r238220.
     4
     5        Introduced failing tests to iOS and is slowing down EWS
     6
     7        Reverted changeset:
     8
     9        "[css-grid] Consider scrollbars in
     10        populateGridPositionsForDirection()"
     11        https://bugs.webkit.org/show_bug.cgi?id=191656
     12        https://trac.webkit.org/changeset/238220
     13
    1142018-11-15  Youenn Fablet  <youenn@apple.com>
    215

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/w3c-import.log

    r238220 r238242  
    2525/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002.html
    2626/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-line-001.html
    27 /LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001-expected.html
    28 /LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-001.html
    29 /LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001-expected.html
    30 /LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html
    31 /LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001-expected.html
    32 /LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html
    3327/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-display-grid-001-expected.xht
    3428/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-display-grid-001.html

  • trunk/Source/WebCore/ChangeLog

    r238240 r238242  
     12018-11-15  Truitt Savell  <tsavell@apple.com>
     2
     3        Unreviewed, rolling out r238220.
     4
     5        Introduced failing tests to iOS and is slowing down EWS
     6
     7        Reverted changeset:
     8
     9        "[css-grid] Consider scrollbars in
     10        populateGridPositionsForDirection()"
     11        https://bugs.webkit.org/show_bug.cgi?id=191656
     12        https://trac.webkit.org/changeset/238220
     13
    1142018-11-15  Jiewen Tan  <jiewen_tan@apple.com>
    215

  • trunk/Source/WebCore/rendering/RenderGrid.cpp

    r238220 r238242  
    10041004    auto& positions = isRowAxis ? m_columnPositions : m_rowPositions;
    10051005    positions.resize(numberOfLines);
    1006 
    10071006    auto borderAndPadding = isRowAxis ? borderAndPaddingLogicalLeft() : borderAndPaddingBefore();
    1008     // If we are in horizontal writing mode and RTL direction the scrollbar is painted on the left,
    1009     // so we need to take into account when computing the position of the columns.
    1010     if (isRowAxis && style().isHorizontalWritingMode() && !style().isLeftToRightDirection())
    1011         borderAndPadding += scrollbarLogicalWidth();
    1012 
    10131007    positions[0] = borderAndPadding + offset.positionOffset;
    10141008    if (numberOfLines > 1) {
Note: See TracChangeset for help on using the changeset viewer.