Changeset 238247 in webkit


Ignore:
Timestamp:
Nov 15, 2018 1:31:34 PM (5 years ago)
Author:
jiewen_tan@apple.com
Message:

Unreviewed, comment improvement over r238166.

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):

  • UIProcess/WebAuthentication/fido/CtapHidAuthenticator.h:
Location:
trunk/Source/WebKit
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r238246 r238247  
     12018-11-14  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Unreviewed, comment improvement over r238166.
     4
     5        * UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
     6        (WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):
     7        * UIProcess/WebAuthentication/fido/CtapHidAuthenticator.h:
     8
    192018-11-15  Jiewen Tan  <jiewen_tan@apple.com>
    210

  • trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp

    r238246 r238247  
    612612            hid.subStage = MockWebAuthenticationConfiguration::Hid::SubStage::Msg;
    613613
    614 
    615614        auto error = WebKit::toImpl(static_cast<WKStringRef>(WKDictionaryGetItemForKey(hidRef, adoptWK(WKStringCreateWithUTF8CString("Error")).get())))->string();
    616615        if (error == "success")

  • trunk/Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidAuthenticator.h

    r238166 r238247  
    3737class CtapHidAuthenticator final : public Authenticator {
    3838public:
    39     // FIXME(191526): Should store AuthenticatorSupportedOptions::UserVerificationAvailability.
    4039    static Ref<CtapHidAuthenticator> create(std::unique_ptr<CtapHidDriver>&& driver, fido::AuthenticatorGetInfoResponse&& info)
    4140    {
Note: See TracChangeset for help on using the changeset viewer.