Changeset 238286 in webkit

Timestamp:

Nov 16, 2018 9:51:10 AM (5 years ago)

Author:

Antti Koivisto

Message:

REGRESSION(r237467) [PSON] iOS: Going back to a page sometimes doesn't restore the full page
​https://bugs.webkit.org/show_bug.cgi?id=191737

Reviewed by Simon Fraser.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setLayerTreeStateIsFrozen):

Layer tree should stay frozen in m_shouldResetDrawingArea state. Otherwise spurious commit transactions may
mess up state on UI process side.

Specifically WKWebView._needsResetViewStateAfterCommitLoadForMainFrame would get stuck to TRUE and prevent
all viewport updates because WKWebView._firstPaintAfterCommitLoadTransactionID has value greater
than any current transaction IDs.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-11-16  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION(r237467) [PSON] iOS: Going back to a page sometimes doesn't restore the full page
+        https://bugs.webkit.org/show_bug.cgi?id=191737
+
+        Reviewed by Simon Fraser.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::setLayerTreeStateIsFrozen):
+
+        Layer tree should stay frozen in m_shouldResetDrawingArea state. Otherwise spurious commit transactions may
+        mess up state on UI process side.
+
+        Specifically WKWebView._needsResetViewStateAfterCommitLoadForMainFrame would get stuck to TRUE and prevent
+        all viewport updates because WKWebView._firstPaintAfterCommitLoadTransactionID has value greater
+        than any current transaction IDs.
+
 2018-11-16  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

@@ -2334 +2334 @@
         return;
 
-    drawingArea->setLayerTreeStateIsFrozen(frozen || m_isSuspended);
+    drawingArea->setLayerTreeStateIsFrozen(frozen || m_isSuspended || m_shouldResetDrawingArea);
 }