Changeset 238366 in webkit


Ignore:
Timestamp:
Nov 18, 2018 9:23:50 PM (5 years ago)
Author:
Fujii Hironori
Message:

REGRESSION(r238039) WebCore::JSDOMGlobalObject::createStructure is using JSC::Structure::create without including StructureInlines.h
https://bugs.webkit.org/show_bug.cgi?id=191626

Reviewed by Yusuke Suzuki.

JSC::Structure::create is used everywhere. It should be defined in
Structure.h, not in StructureInlines.h.

  • runtime/Structure.h:

(JSC::Structure::create): Moved.

  • runtime/StructureInlines.h: Moved JSC::Structure::create.
Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r238365 r238366  
     12018-11-18  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        REGRESSION(r238039) WebCore::JSDOMGlobalObject::createStructure is using JSC::Structure::create without including StructureInlines.h
     4        https://bugs.webkit.org/show_bug.cgi?id=191626
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        JSC::Structure::create is used everywhere. It should be defined in
     9        Structure.h, not in StructureInlines.h.
     10
     11        * runtime/Structure.h:
     12        (JSC::Structure::create): Moved.
     13        * runtime/StructureInlines.h: Moved JSC::Structure::create.
     14
    1152018-11-18  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
    216
  • trunk/Source/JavaScriptCore/runtime/Structure.h

    r237469 r238366  
    829829};
    830830
     831inline Structure* Structure::create(VM& vm, JSGlobalObject* globalObject, JSValue prototype, const TypeInfo& typeInfo, const ClassInfo* classInfo, IndexingType indexingType, unsigned inlineCapacity)
     832{
     833    ASSERT(vm.structureStructure);
     834    ASSERT(classInfo);
     835    Structure* structure = new (NotNull, allocateCell<Structure>(vm.heap)) Structure(vm, globalObject, prototype, typeInfo, classInfo, indexingType, inlineCapacity);
     836    structure->finishCreation(vm);
     837    return structure;
     838}
     839
    831840} // namespace JSC
  • trunk/Source/JavaScriptCore/runtime/StructureInlines.h

    r237469 r238366  
    3535namespace JSC {
    3636
    37 inline Structure* Structure::create(VM& vm, JSGlobalObject* globalObject, JSValue prototype, const TypeInfo& typeInfo, const ClassInfo* classInfo, IndexingType indexingType, unsigned inlineCapacity)
    38 {
    39     ASSERT(vm.structureStructure);
    40     ASSERT(classInfo);
    41     Structure* structure = new (NotNull, allocateCell<Structure>(vm.heap)) Structure(vm, globalObject, prototype, typeInfo, classInfo, indexingType, inlineCapacity);
    42     structure->finishCreation(vm);
    43     return structure;
    44 }
    45 
    4637inline Structure* Structure::createStructure(VM& vm)
    4738{
Note: See TracChangeset for help on using the changeset viewer.