Changeset 238413 in webkit

Timestamp:

Nov 21, 2018 1:11:23 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r237845): [cairo] Hyperlink underscore layout issue
​https://bugs.webkit.org/show_bug.cgi?id=191630

Reviewed by Michael Catanzaro.

Only flip Y in GlyphToPathTranslator for ports using CG.

• platform/graphics/FontCascade.cpp:

(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/FontCascade.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r237845): [cairo] Hyperlink underscore layout issue
+        https://bugs.webkit.org/show_bug.cgi?id=191630
+
+        Reviewed by Michael Catanzaro.
+
+        Only flip Y in GlyphToPathTranslator for ports using CG.
+
+        * platform/graphics/FontCascade.cpp:
+        (WebCore::GlyphToPathTranslator::GlyphToPathTranslator):
+
 2018-11-21  Alicia Boya García  <aboya@igalia.com>
 

trunk/Source/WebCore/platform/graphics/FontCascade.cpp

@@ -1740 +1740 @@
         , m_glyphBuffer(glyphBuffer)
         , m_fontData(glyphBuffer.fontAt(m_index))
-        , m_translation(AffineTransform::translation(textOrigin.x(), textOrigin.y()).scale(1, -1))
+        , m_translation(AffineTransform::translation(textOrigin.x(), textOrigin.y()))
     {
+#if USE(CG)
+        m_translation.flipY();
+#endif
     }