Changeset 238426 in webkit
- Timestamp:
- Nov 21, 2018 10:58:13 AM (5 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r238422 r238426 1 2018-11-21 Claudio Saavedra <csaavedra@igalia.com> 2 3 [SOUP] Follow-up robustness improvements to the certificate decoder 4 https://bugs.webkit.org/show_bug.cgi?id=191892 5 6 Reviewed by Michael Catanzaro. 7 8 If at any point the certificate fails to be constructed from 9 the DER data, bail out. Likewise, if the certificate returned 10 is NULL, return false from the decoder to notify the failure 11 to decode it. 12 13 * platform/network/soup/CertificateInfo.h: 14 (WTF::Persistence::certificateFromCertificatesDataList): 15 (WTF::Persistence::Coder<WebCore::CertificateInfo>::decode): 16 1 17 2018-11-21 Zalan Bujtas <zalan@apple.com> 2 18 -
trunk/Source/WebCore/platform/network/soup/CertificateInfo.h
r238417 r238426 120 120 certificate = adoptGRef(G_TLS_CERTIFICATE(g_initable_new( 121 121 certificateType, nullptr, nullptr, "certificate", certificateData.get(), "issuer", certificate.get(), nullptr))); 122 if (!certificate) 123 break; 122 124 } 123 125 … … 146 148 if (certificatesDataList.isEmpty()) 147 149 return true; 148 certificateInfo.setCertificate(certificateFromCertificatesDataList(certificatesDataList).get()); 150 auto certificate = certificateFromCertificatesDataList(certificatesDataList); 151 if (!certificate) 152 return false; 153 certificateInfo.setCertificate(certificate.get()); 149 154 150 155 uint32_t tlsErrors;
Note: See TracChangeset
for help on using the changeset viewer.