Changeset 238473 in webkit


Ignore:
Timestamp:
Nov 24, 2018 5:45:54 PM (5 years ago)
Author:
Wenson Hsieh
Message:

[Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
https://bugs.webkit.org/show_bug.cgi?id=191945

Reviewed by Anders Carlsson.

Source/WebCore:

Run update-webkit-localizable-strings.

  • en.lproj/Localizable.strings:

Source/WebKit:

Replace some a couple of command undo action name descriptions with "Undo action name", to match all other
edit commands.

  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

Location:
trunk/Source
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r238472 r238473  
     12018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
     4        https://bugs.webkit.org/show_bug.cgi?id=191945
     5
     6        Reviewed by Anders Carlsson.
     7
     8        Run `update-webkit-localizable-strings`.
     9
     10        * en.lproj/Localizable.strings:
     11
    1122018-11-24  Sam Weinig  <sam@webkit.org>
    213
  • trunk/Source/WebCore/en.lproj/Localizable.strings

    r238406 r238473  
    188188"Controls" = "Controls";
    189189
    190 /* Convert to ordered list action name */
     190/* Undo action name */
    191191"Convert to Ordered List (Undo action name)" = "Convert to Ordered List";
    192192
    193 /* Convert to unordered list action name */
     193/* Undo action name */
    194194"Convert to Unordered List (Undo action name)" = "Convert to Unordered List";
    195195
     
    596596"Search in Spotlight" = "Search in Spotlight";
    597597
     598/* Search the Web context menu item */
     599"Search the Web" = "Search the Web";
     600
    598601/* Search with search provider context menu item with provider name inserted */
    599602"Search with %@" = "Search with %@";
    600603
    601 /* Search the Web context menu item */
    602 "Search the Web" = "Search the Web";
    603 
    604604/* Validation message for required file inputs that have no value */
    605605"Select a file" = "Select a file";
     
    821821"URL field" = "URL field";
    822822
     823/* Unacceptable TLS certificate error */
     824"Unacceptable TLS certificate" = "Unacceptable TLS certificate";
     825
    823826/* Underline context menu item */
    824827"Underline" = "Underline";
  • trunk/Source/WebKit/ChangeLog

    r238471 r238473  
     12018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
     4        https://bugs.webkit.org/show_bug.cgi?id=191945
     5
     6        Reviewed by Anders Carlsson.
     7
     8        Replace some a couple of command undo action name descriptions with "Undo action name", to match all other
     9        edit commands.
     10
     11        * UIProcess/WebEditCommandProxy.cpp:
     12        (WebKit::WebEditCommandProxy::nameForEditAction):
     13
    1142018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
    215
  • trunk/Source/WebKit/UIProcess/WebEditCommandProxy.cpp

    r238080 r238473  
    175175    // despite the fact that ordered and unordered lists are not necessarily displayed using bullets and numerals.
    176176    case EditAction::ConvertToOrderedList:
    177         return WEB_UI_STRING_KEY("Convert to Ordered List", "Convert to Ordered List (Undo action name)", "Convert to ordered list action name");
     177        return WEB_UI_STRING_KEY("Convert to Ordered List", "Convert to Ordered List (Undo action name)", "Undo action name");
    178178    case EditAction::ConvertToUnorderedList:
    179         return WEB_UI_STRING_KEY("Convert to Unordered List", "Convert to Unordered List (Undo action name)", "Convert to unordered list action name");
     179        return WEB_UI_STRING_KEY("Convert to Unordered List", "Convert to Unordered List (Undo action name)", "Undo action name");
    180180    }
    181181    return String();
  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r238461 r238473  
     12018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
     4        https://bugs.webkit.org/show_bug.cgi?id=191945
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * WebCoreSupport/WebEditorClient.mm:
     9        (undoNameForEditAction):
     10
    1112018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
    212
  • trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm

    r238080 r238473  
    654654    case EditAction::Delete: return UI_STRING_KEY_INTERNAL("Delete", "Delete (Undo action name)", "Undo action name");
    655655    case EditAction::Dictation: return UI_STRING_KEY_INTERNAL("Dictation", "Dictation (Undo action name)", "Undo action name");
    656     case EditAction::ConvertToOrderedList: return UI_STRING_KEY_INTERNAL("Convert to Ordered List", "Convert to Ordered List (Undo action name)", "Convert to ordered list action name");
    657     case EditAction::ConvertToUnorderedList: return UI_STRING_KEY_INTERNAL("Convert to Unordered List", "Convert to Unordered List (Undo action name)", "Convert to unordered list action name");
     656    case EditAction::ConvertToOrderedList: return UI_STRING_KEY_INTERNAL("Convert to Ordered List", "Convert to Ordered List (Undo action name)", "Undo action name");
     657    case EditAction::ConvertToUnorderedList: return UI_STRING_KEY_INTERNAL("Convert to Unordered List", "Convert to Unordered List (Undo action name)", "Undo action name");
    658658    }
    659659    return nil;
Note: See TracChangeset for help on using the changeset viewer.