Changeset 238513 in webkit
- Timestamp:
- Nov 26, 2018 12:42:22 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 4 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r238512 r238513 1 2018-11-26 Daniel Bates <dabates@apple.com> 2 3 REGRESSION (r238078): Do not draw caps lock indicator when Strong Password button is shown 4 https://bugs.webkit.org/show_bug.cgi?id=191969 5 <rdar://problem/46247569> 6 7 Reviewed by Dean Jackson. 8 9 Add tests to ensure that we show or hide the caps lock indicator depending on whether the 10 Strong Password button is visible. 11 12 * TestExpectations: Skip the tests below on all platforms. We will selectively enable them on Mac. 13 * fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after-hiding-auto-fill-strong-password-button-expected.html: Added. 14 * fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after-hiding-auto-fill-strong-password-button.html: Added. 15 * fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible-expected.html: Added. 16 * fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible.html: Added. 17 * platform/mac-wk2/TestExpectations: Mark the tests above as PASS so that we run them. 18 1 19 2018-11-26 Daniel Bates <dabates@apple.com> 2 20 -
trunk/LayoutTests/TestExpectations
r238457 r238513 400 400 401 401 fast/events/detect-caps-lock.html [ Skip ] 402 fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after-hiding-auto-fill-strong-password-button.html [ Skip ] 403 fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible.html [ Skip ] 402 404 403 405 # This test currently only works for mac-wk2 -
trunk/LayoutTests/platform/mac-wk2/TestExpectations
r238438 r238513 69 69 70 70 [ Mojave+ ] fast/events/detect-caps-lock.html [ Pass ] 71 [ Mojave+ ] fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after-hiding-auto-fill-strong-password-button.html [ Pass ] 72 [ Mojave+ ] fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible.html [ Pass ] 71 73 72 74 fast/events/inactive-window-no-mouse-event.html [ Pass ] -
trunk/Source/WebCore/ChangeLog
r238504 r238513 1 2018-11-26 Daniel Bates <dabates@apple.com> 2 3 REGRESSION (r238078): Do not draw caps lock indicator when Strong Password button is shown 4 https://bugs.webkit.org/show_bug.cgi?id=191969 5 <rdar://problem/46247569> 6 7 Reviewed by Dean Jackson. 8 9 Following r238078 we now support drawing the caps lock indicator in password fields on iOS. 10 However it is not meaningful to show the caps lock indicator when the Strong Password button 11 is visible because the password field is not editable. We should not paint the caps lock 12 indicator when the Strong Password button is visible. 13 14 Tests: fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after-hiding-auto-fill-strong-password-button.html 15 fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible.html 16 17 * html/TextFieldInputType.cpp: 18 (WebCore::TextFieldInputType::shouldDrawCapsLockIndicator const): Do not draw the caps 19 lock indicator when the password field has the Strong Password button. 20 (WebCore::TextFieldInputType::updateAutoFillButton): Call capsLockStateMayHaveChanged() to 21 update the visibility of the caps lock indicator when the auto fill button has changed. 22 1 23 2018-11-26 Sam Weinig <sam@webkit.org> 2 24 -
trunk/Source/WebCore/html/TextFieldInputType.cpp
r237647 r238513 725 725 return false; 726 726 727 if (element()->hasAutoFillStrongPasswordButton()) 728 return false; 729 727 730 RefPtr<Frame> frame = element()->document().frame(); 728 731 if (!frame) … … 793 796 void TextFieldInputType::updateAutoFillButton() 794 797 { 798 capsLockStateMayHaveChanged(); 799 795 800 if (shouldDrawAutoFillButton()) { 796 801 if (!m_container)
Note: See TracChangeset
for help on using the changeset viewer.