Changeset 238516 in webkit


Ignore:
Timestamp:
Nov 26, 2018 1:19:52 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Picture-in-picture window size changes unnecesarily when URL changes.
https://bugs.webkit.org/show_bug.cgi?id=191787

Patch by Jeremy Jones <jeremyj@apple.com> on 2018-11-26
Reviewed by Jer Noble.

When loading a new URL, the video dimensions are temporarily 0,0. Instead of
defaulting back to 4:3 sized pip window temporarily, keep the old dimensions until
there is a new valid size.

  • platform/ios/VideoFullscreenInterfaceAVKit.mm:

(VideoFullscreenInterfaceAVKit::videoDimensionsChanged):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r238515 r238516  
     12018-11-26  Jeremy Jones  <jeremyj@apple.com>
     2
     3        Picture-in-picture window size changes unnecesarily when URL changes.
     4        https://bugs.webkit.org/show_bug.cgi?id=191787
     5
     6        Reviewed by Jer Noble.
     7
     8        When loading a new URL, the video dimensions are temporarily 0,0. Instead of
     9        defaulting back to 4:3 sized pip window temporarily, keep the old dimensions until
     10        there is a new valid size.
     11
     12        * platform/ios/VideoFullscreenInterfaceAVKit.mm:
     13        (VideoFullscreenInterfaceAVKit::videoDimensionsChanged):
     14
    1152018-11-26  Andy Estes  <aestes@apple.com>
    216
  • trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm

    r238257 r238516  
    785785void VideoFullscreenInterfaceAVKit::videoDimensionsChanged(const FloatSize& videoDimensions)
    786786{
     787    if (videoDimensions.isZero())
     788        return;
     789   
    787790    WebAVPlayerLayer *playerLayer = (WebAVPlayerLayer *)[m_playerLayerView playerLayer];
    788791
Note: See TracChangeset for help on using the changeset viewer.