Changeset 238579 in webkit
- Timestamp:
- Nov 27, 2018 2:40:51 PM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r238577 r238579 1 2018-11-27 Jiewen Tan <jiewen_tan@apple.com> 2 3 (r238246) [ MacOS Debug ] Layout Test http/wpt/webauthn/ctap-hid-failure.https.html is Crashing 4 https://bugs.webkit.org/show_bug.cgi?id=191757 5 6 Reviewed by Chris Dumez. 7 8 Wrong nonce error causes retransmission, which then trigger wrong nonce error. This is expected 9 behavior for mock testing. However, the main thread could time out when MockHidConnection::send 10 is excuting the block on another thread. The block will then return without invoking the callback, 11 which triggers this WTFCrash. The solution is always invoking the callback before return in the 12 block. 13 14 * UIProcess/WebAuthentication/Mock/MockHidConnection.cpp: 15 (WebKit::MockHidConnection::send): 16 1 17 2018-11-27 Keith Rollin <krollin@apple.com> 2 18 -
trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
r238246 r238579 74 74 ASSERT(!RunLoop::isMain()); 75 75 RunLoop::main().dispatch([weakThis, data = WTFMove(data), callback = WTFMove(callback)]() mutable { 76 if (!weakThis) 76 if (!weakThis) { 77 callback(DataSent::No); 77 78 return; 79 } 78 80 79 81 weakThis->assembleRequest(WTFMove(data));
Note: See TracChangeset
for help on using the changeset viewer.