Changeset 238595 in webkit

Timestamp:

Nov 27, 2018 5:48:36 PM (5 years ago)

Author:

mark.lam@apple.com

Message:

ASSERTION FAILED: capacity && isPageAligned(capacity) in JSC::CLoopStack::CLoopStack(JSC::VM&).
​https://bugs.webkit.org/show_bug.cgi?id=192018

Reviewed by Saam Barati.

This assertion failed because the regress-191579.js test was specifying
--maxPerThreadStackUsage=400000 i.e. it was running with a stack size that is not
page aligned. Given that the user can specify any arbitrary stack size, and the
CLoop stack expects to be page aligned, we'll just round up the requested capacity
to the next page alignment.

• interpreter/CLoopStack.cpp:

(JSC::CLoopStack::CLoopStack):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• interpreter/CLoopStack.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-11-27  Mark Lam  <mark.lam@apple.com>
+
+        ASSERTION FAILED: capacity && isPageAligned(capacity) in JSC::CLoopStack::CLoopStack(JSC::VM&).
+        https://bugs.webkit.org/show_bug.cgi?id=192018
+
+        Reviewed by Saam Barati.
+
+        This assertion failed because the regress-191579.js test was specifying
+        --maxPerThreadStackUsage=400000 i.e. it was running with a stack size that is not
+        page aligned.  Given that the user can specify any arbitrary stack size, and the
+        CLoop stack expects to be page aligned, we'll just round up the requested capacity
+        to the next page alignment.
+
+        * interpreter/CLoopStack.cpp:
+        (JSC::CLoopStack::CLoopStack):
+
 2018-11-27  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/interpreter/CLoopStack.cpp

@@ -57 +57 @@
 {
     size_t capacity = Options::maxPerThreadStackUsage();
+    capacity = WTF::roundUpToMultipleOf(pageSize(), capacity);
     ASSERT(capacity && isPageAligned(capacity));