Changeset 238600 in webkit


Ignore:
Timestamp:
Nov 27, 2018 7:05:16 PM (5 years ago)
Author:
Simon Fraser
Message:

Fix the mis-spelled "m_clienstWaitingForAsyncDecoding"
https://bugs.webkit.org/show_bug.cgi?id=192060

Reviewed by Wenson Hsieh.

Fix the mis-spelling of "m_clienstWaitingForAsyncDecoding".

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::didRemoveClient):
(WebCore::CachedImage::isClientWaitingForAsyncDecoding const):
(WebCore::CachedImage::addClientWaitingForAsyncDecoding):
(WebCore::CachedImage::removeAllClientsWaitingForAsyncDecoding):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::createImage):
(WebCore::CachedImage::imageFrameAvailable):

  • loader/cache/CachedImage.h:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r238597 r238600  
     12018-11-27  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Fix the mis-spelled "m_clienstWaitingForAsyncDecoding"
     4        https://bugs.webkit.org/show_bug.cgi?id=192060
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        Fix the mis-spelling of "m_clienstWaitingForAsyncDecoding".
     9
     10        * loader/cache/CachedImage.cpp:
     11        (WebCore::CachedImage::didRemoveClient):
     12        (WebCore::CachedImage::isClientWaitingForAsyncDecoding const):
     13        (WebCore::CachedImage::addClientWaitingForAsyncDecoding):
     14        (WebCore::CachedImage::removeAllClientsWaitingForAsyncDecoding):
     15        (WebCore::CachedImage::allClientsRemoved):
     16        (WebCore::CachedImage::clear):
     17        (WebCore::CachedImage::createImage):
     18        (WebCore::CachedImage::imageFrameAvailable):
     19        * loader/cache/CachedImage.h:
     20
    1212018-11-27  Mark Lam  <mark.lam@apple.com>
    222
  • trunk/Source/WebCore/loader/cache/CachedImage.cpp

    r237266 r238600  
    131131
    132132    m_pendingContainerContextRequests.remove(&static_cast<CachedImageClient&>(client));
    133     m_clienstWaitingForAsyncDecoding.remove(&static_cast<CachedImageClient&>(client));
     133    m_clientsWaitingForAsyncDecoding.remove(&static_cast<CachedImageClient&>(client));
    134134
    135135    if (m_svgImageCache)
     
    143143bool CachedImage::isClientWaitingForAsyncDecoding(CachedImageClient& client) const
    144144{
    145     return m_clienstWaitingForAsyncDecoding.contains(&client);
     145    return m_clientsWaitingForAsyncDecoding.contains(&client);
    146146}
    147147
     
    149149{
    150150    ASSERT(client.resourceClientType() == CachedImageClient::expectedType());
    151     if (m_clienstWaitingForAsyncDecoding.contains(&client))
     151    if (m_clientsWaitingForAsyncDecoding.contains(&client))
    152152        return;
    153153    if (!m_clients.contains(&client)) {
     
    155155        // renderer uses the style of the <body> element, see RenderView::rendererForRootBackground().
    156156        // In this case, the client we are asked to add is the root box renderer. Since we can't add
    157         // a client to m_clienstWaitingForAsyncDecoding unless it is one of the m_clients, we are going
     157        // a client to m_clientsWaitingForAsyncDecoding unless it is one of the m_clients, we are going
    158158        // to cancel the repaint optimization we do in CachedImage::imageFrameAvailable() by adding
    159         // all the m_clients to m_clienstWaitingForAsyncDecoding.
     159        // all the m_clients to m_clientsWaitingForAsyncDecoding.
    160160        CachedResourceClientWalker<CachedImageClient> walker(m_clients);
    161161        while (auto* client = walker.next())
    162             m_clienstWaitingForAsyncDecoding.add(client);
     162            m_clientsWaitingForAsyncDecoding.add(client);
    163163    } else
    164         m_clienstWaitingForAsyncDecoding.add(&client);
     164        m_clientsWaitingForAsyncDecoding.add(&client);
    165165}
    166166   
    167167void CachedImage::removeAllClientsWaitingForAsyncDecoding()
    168168{
    169     if (m_clienstWaitingForAsyncDecoding.isEmpty() || !hasImage() || !is<BitmapImage>(image()))
     169    if (m_clientsWaitingForAsyncDecoding.isEmpty() || !hasImage() || !is<BitmapImage>(image()))
    170170        return;
    171171    downcast<BitmapImage>(image())->stopAsyncDecodingQueue();
    172     for (auto* client : m_clienstWaitingForAsyncDecoding)
     172    for (auto* client : m_clientsWaitingForAsyncDecoding)
    173173        client->imageChanged(this);
    174     m_clienstWaitingForAsyncDecoding.clear();
     174    m_clientsWaitingForAsyncDecoding.clear();
    175175}
    176176
     
    197197{
    198198    m_pendingContainerContextRequests.clear();
    199     m_clienstWaitingForAsyncDecoding.clear();
     199    m_clientsWaitingForAsyncDecoding.clear();
    200200    if (m_image && !errorOccurred())
    201201        m_image->resetAnimation();
     
    339339    clearImage();
    340340    m_pendingContainerContextRequests.clear();
    341     m_clienstWaitingForAsyncDecoding.clear();
     341    m_clientsWaitingForAsyncDecoding.clear();
    342342    setEncodedSize(0);
    343343}
     
    363363        }
    364364        m_pendingContainerContextRequests.clear();
    365         m_clienstWaitingForAsyncDecoding.clear();
     365        m_clientsWaitingForAsyncDecoding.clear();
    366366    }
    367367}
     
    628628    while (CachedImageClient* client = clientWalker.next()) {
    629629        // All the clients of animated images have to be notified. The new frame has to be drawn in all of them.
    630         if (animatingState == ImageAnimatingState::No && !m_clienstWaitingForAsyncDecoding.contains(client))
     630        if (animatingState == ImageAnimatingState::No && !m_clientsWaitingForAsyncDecoding.contains(client))
    631631            continue;
    632632        if (client->imageFrameAvailable(*this, animatingState, changeRect) == VisibleInViewportState::Yes)
     
    638638
    639639    if (decodingStatus != DecodingStatus::Partial)
    640         m_clienstWaitingForAsyncDecoding.clear();
     640        m_clientsWaitingForAsyncDecoding.clear();
    641641}
    642642
  • trunk/Source/WebCore/loader/cache/CachedImage.h

    r233872 r238600  
    173173    ContainerContextRequests m_pendingContainerContextRequests;
    174174
    175     HashSet<CachedImageClient*> m_clienstWaitingForAsyncDecoding;
     175    HashSet<CachedImageClient*> m_clientsWaitingForAsyncDecoding;
    176176
    177177    RefPtr<CachedImageObserver> m_imageObserver;
Note: See TracChangeset for help on using the changeset viewer.