Changeset 238620 in webkit


Ignore:
Timestamp:
Nov 28, 2018 10:16:10 AM (5 years ago)
Author:
Fujii Hironori
Message:

Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp
​https://bugs.webkit.org/show_bug.cgi?id=191853

Reviewed by Michael Catanzaro.

In r235845, I excluded InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp from unify source builds in order to
work around a MSVC bug.

Then, I commited a different workaround for the MSVC bug in
r238386. Now, we can include InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp in unified source builds. Revert
r235845.

  • Sources.txt: Removed @no-unify of InjectedBundleRangeHandle.cpp

and InjectedBundleNodeHandle.cpp

  • WebKit.xcodeproj/project.pbxproj: Unchecked Target Membership

not to be compiled by XCode.

Location:
trunk/Source/WebKit
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r238617 r238620  
     12018-11-28  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp
     4        https://bugs.webkit.org/show_bug.cgi?id=191853
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        In r235845, I excluded InjectedBundleRangeHandle.cpp and
     9        InjectedBundleNodeHandle.cpp from unify source builds in order to
     10        work around a MSVC bug.
     11
     12        Then, I commited a different workaround for the MSVC bug in
     13        r238386. Now, we can include InjectedBundleRangeHandle.cpp and
     14        InjectedBundleNodeHandle.cpp in unified source builds. Revert
     15        r235845.
     16
     17        * Sources.txt: Removed @no-unify of InjectedBundleRangeHandle.cpp
     18        and InjectedBundleNodeHandle.cpp
     19        * WebKit.xcodeproj/project.pbxproj: Unchecked Target Membership
     20        not to be compiled by XCode.
     21
    1222018-11-28  Joseph Pecoraro  <pecoraro@apple.com>
    223

  • trunk/Source/WebKit/Sources.txt

    r238446 r238620  
    457457
    458458WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp
    459 WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp @no-unify
    460 WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp @no-unify
     459WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
     460WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp
    461461
    462462WebProcess/MediaStream/MediaDeviceSandboxExtensions.cpp

  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r238538 r238620  
    413413                26F10BE919187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.m in Sources */ = {isa = PBXBuildFile; fileRef = 26F10BE719187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.m */; };
    414414                26F9A83B18A3468100AEB88A /* WKWebViewPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F9A83A18A3463F00AEB88A /* WKWebViewPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
    415                 2749F6442146561B008380BF /* InjectedBundleNodeHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC4BEEAA120A0A5F00FBA0C7 /* InjectedBundleNodeHandle.cpp */; };
    416                 2749F6452146561E008380BF /* InjectedBundleRangeHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC33E0D012408E8600360F3F /* InjectedBundleRangeHandle.cpp */; };
    417415                290F4272172A0C7400939FF0 /* ChildProcessSupplement.h in Headers */ = {isa = PBXBuildFile; fileRef = 290F4271172A0C7400939FF0 /* ChildProcessSupplement.h */; };
    418416                29232DF418B29D6800D0596F /* WKAccessibilityWebPageObjectMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 29232DF318B29D6800D0596F /* WKAccessibilityWebPageObjectMac.h */; };
    … …  
    1073810736                                2D92A780212B6A7100F493FD /* Encoder.cpp in Sources */,
    1073910737                                1AA576021496B97900A4EE06 /* EventDispatcherMessageReceiver.cpp in Sources */,
    10740                                 2749F6442146561B008380BF /* InjectedBundleNodeHandle.cpp in Sources */,
    10741                                 2749F6452146561E008380BF /* InjectedBundleRangeHandle.cpp in Sources */,
    1074210738                                2D913441212CF9F000128AFD /* JSNPMethod.cpp in Sources */,
    1074310739                                2D913442212CF9F000128AFD /* JSNPObject.cpp in Sources */,
Note: See TracChangeset for help on using the changeset viewer.