Changeset 238641 in webkit

Timestamp:

Nov 28, 2018 2:12:22 PM (5 years ago)

Author:

achristensen@apple.com

Message:

Fix iOS API test after r238585
​https://bugs.webkit.org/show_bug.cgi?id=192022

• TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(TEST):
On iOS, a safe browsing warning over a WKWebView with frame of {0, 0, 0, 0} has a size of {0, 0}, which is fine.
The test was added to catch a bug on Mac platforms, so testing it only on Mac will catch any regression.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-11-28  Alex Christensen  <achristensen@webkit.org>
+
+        Fix iOS API test after r238585
+        https://bugs.webkit.org/show_bug.cgi?id=192022
+
+        * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+        (TEST):
+        On iOS, a safe browsing warning over a WKWebView with frame of {0, 0, 0, 0} has a size of {0, 0}, which is fine.
+        The test was added to catch a bug on Mac platforms, so testing it only on Mac will catch any regression.
+
 2018-11-28  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm

@@ -213 +213 @@
     auto warning = [webView _safeBrowsingWarning];
     EXPECT_EQ(warning.subviews.count, 1ull);
+#if PLATFORM(MAC)
     EXPECT_GT(warning.subviews.firstObject.subviews[2].frame.size.height, 0);
+#endif
     checkTitleAndClick(warning.subviews.firstObject.subviews[4], "Show Details");
     EXPECT_EQ(warning.subviews.count, 2ull);