Changeset 238651 in webkit


Ignore:
Timestamp:
Nov 28, 2018 5:29:54 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Updating href on linearGradient and radialGradient doesn't update its rendering
https://bugs.webkit.org/show_bug.cgi?id=191934

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-11-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

Mark the gradient renderer for repaint when the value of the 'href'
attribute changes.

Tests: fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html

fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree.html
svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html

  • svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::svgAttributeChanged):

LayoutTests:

  • fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree-expected.html: Added.
  • fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html: Added.
  • fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree-expected.html: Added.
  • fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree.html: Added.
  • svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop-expected.html: Added.
  • svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html: Added.
  • svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop-expected.html: Added.
  • svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html: Added.
Location:
trunk
Files:
8 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r238643 r238651  
     12018-11-28  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        Updating href on linearGradient and radialGradient doesn't update its rendering
     4        https://bugs.webkit.org/show_bug.cgi?id=191934
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        * fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree-expected.html: Added.
     9        * fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html: Added.
     10        * fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree-expected.html: Added.
     11        * fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree.html: Added.
     12        * svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop-expected.html: Added.
     13        * svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html: Added.
     14        * svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop-expected.html: Added.
     15        * svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html: Added.
     16
    1172018-11-28  Truitt Savell  <tsavell@apple.com>
    218
  • trunk/Source/WebCore/ChangeLog

    r238642 r238651  
     12018-11-28  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        Updating href on linearGradient and radialGradient doesn't update its rendering
     4        https://bugs.webkit.org/show_bug.cgi?id=191934
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Mark the gradient renderer for repaint when the value of the 'href'
     9        attribute changes.
     10
     11        Tests: fast/shadow-dom/svg-linear-gradient-dynamic-update-href-in-shadow-tree.html
     12               fast/shadow-dom/svg-radial-gradient-dynamic-update-href-in-shadow-tree.html
     13               svg/dynamic-updates/SVGLinearGradientElement-svgdom-href-prop.html
     14               svg/dynamic-updates/SVGRadialGradientElement-svgdom-href-prop.html
     15
     16        * svg/SVGGradientElement.cpp:
     17        (WebCore::SVGGradientElement::svgAttributeChanged):
     18
     19
    1202018-11-28  Youenn Fablet  <youenn@apple.com>
    221
  • trunk/Source/WebCore/svg/SVGGradientElement.cpp

    r234683 r238651  
    8989void SVGGradientElement::svgAttributeChanged(const QualifiedName& attrName)
    9090{
    91     if (isKnownAttribute(attrName)) {
     91    if (isKnownAttribute(attrName) || SVGURIReference::isKnownAttribute(attrName)) {
    9292        InstanceInvalidationGuard guard(*this);
    9393        if (RenderObject* object = renderer())
Note: See TracChangeset for help on using the changeset viewer.