Changeset 238663 in webkit

Timestamp:

Nov 29, 2018 2:19:56 AM (5 years ago)

Author:

tpopela@redhat.com

Message:

[GTK][WPE] Fix BubblewrapLauncher clang warnings
​https://bugs.webkit.org/show_bug.cgi?id=192086

Reviewed by Michael Catanzaro.

• UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bindPathVar): Initialize the i variable to 0.
(WebKit::setupSeccomp): Initialize the optional datum_b member.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Launcher/glib/BubblewrapLauncher.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-11-29  Tomas Popela  <tpopela@redhat.com>
+
+        [GTK][WPE] Fix BubblewrapLauncher clang warnings
+        https://bugs.webkit.org/show_bug.cgi?id=192086
+
+        Reviewed by Michael Catanzaro.
+
+        * UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+        (WebKit::bindPathVar): Initialize the i variable to 0.
+        (WebKit::setupSeccomp): Initialize the optional datum_b member.
+
 2018-11-28  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp

@@ -472 +472 @@
 
     GUniquePtr<char*> splitPaths(g_strsplit(pathValue, ":", -1));
-    for (size_t i; splitPaths.get()[i]; ++i)
+    for (size_t i = 0; splitPaths.get()[i]; ++i)
         bindIfExists(args, splitPaths.get()[i]);
 
@@ -572 +572 @@
     //    in src/setup-seccomp.c
     struct scmp_arg_cmp cloneArg = SCMP_A0(SCMP_CMP_MASKED_EQ, CLONE_NEWUSER, CLONE_NEWUSER);
-    struct scmp_arg_cmp ttyArg = SCMP_A1(SCMP_CMP_EQ, (int)TIOCSTI);
+    struct scmp_arg_cmp ttyArg = SCMP_A1(SCMP_CMP_EQ, static_cast<scmp_datum_t>(TIOCSTI), static_cast<scmp_datum_t>(0));
     struct {
         int scall;