Changeset 238681 in webkit

Timestamp:

Nov 29, 2018 11:59:43 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Addressed a FIXME by removing an unnecessary call to [NSApplication sharedApplication].
​https://bugs.webkit.org/show_bug.cgi?id=192099

Patch by Suresh Koppisetty <​skoppisetty@apple.com> on 2018-11-29
Reviewed by Geoffrey Garen.

[NSApplication sharedApplication] call is no longer needed in platformInitializeWebProcess as [NSApplication _accessibilityInitialize] calls [NSApplication sharedApplication].

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/cocoa/WebProcessCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-11-29  Suresh Koppisetty  <skoppisetty@apple.com>
+
+        Addressed a FIXME by removing an unnecessary call to [NSApplication sharedApplication].
+        https://bugs.webkit.org/show_bug.cgi?id=192099
+
+        Reviewed by Geoffrey Garen.
+
+        [NSApplication sharedApplication] call is no longer needed in platformInitializeWebProcess as [NSApplication _accessibilityInitialize] calls [NSApplication sharedApplication].
+
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::platformInitializeWebProcess):
+
 2018-11-29  Megan Gardner  <megan_gardner@apple.com>
 

trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

@@ -186 +186 @@
     // Need to initialize accessibility for VoiceOver to work when the WebContent process is using NSRunLoop.
     // Currently, it is also needed to allocate and initialize an NSApplication object.
-    // FIXME: Remove the following line when rdar://problem/36323569 is fixed.
-    [NSApplication sharedApplication];
     [NSApplication _accessibilityInitialize];
 #endif