Changeset 238836 in webkit


Ignore:
Timestamp:
Dec 3, 2018 6:30:27 PM (5 years ago)
Author:
don.olmstead@sony.com
Message:

Fix some unused parameter warnings
​https://bugs.webkit.org/show_bug.cgi?id=192336

Reviewed by Fujii Hironori.

Source/WebCore:

  • Modules/indexeddb/server/IDBSerialization.cpp:

(WebCore::isLegacySerializedIDBKeyData):

  • platform/FileSystem.cpp:

(WebCore::FileSystem::openAndLockFile):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::bindVertexArray):

  • platform/network/curl/CertificateInfo.h:

(WTF::Persistence::Coder<WebCore::CertificateInfo>::encode):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):

Source/WTF:

  • wtf/StackTrace.cpp:

(WTFGetBacktrace):
(WTF::StackTrace::demangle):

  • wtf/generic/MemoryPressureHandlerGeneric.cpp:

(WTF::MemoryPressureHandler::holdOff):
(WTF::MemoryPressureHandler::respondToMemoryPressure):

Location:
trunk/Source
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WTF/ChangeLog

    r238785 r238836  
     12018-12-03  Don Olmstead  <don.olmstead@sony.com>
     2
     3        Fix some unused parameter warnings
     4        https://bugs.webkit.org/show_bug.cgi?id=192336
     5
     6        Reviewed by Fujii Hironori.
     7
     8        * wtf/StackTrace.cpp:
     9        (WTFGetBacktrace):
     10        (WTF::StackTrace::demangle):
     11        * wtf/generic/MemoryPressureHandlerGeneric.cpp:
     12        (WTF::MemoryPressureHandler::holdOff):
     13        (WTF::MemoryPressureHandler::respondToMemoryPressure):
     14
    1152018-12-01  Alexey Proskuryakov  <ap@apple.com>
    216

  • trunk/Source/WTF/wtf/StackTrace.cpp

    r237382 r238836  
    5252    *size = RtlCaptureStackBackTrace(0, *size, stack, 0);
    5353#else
     54    UNUSED_PARAM(stack);
    5455    *size = 0;
    5556#endif
    … …  
    101102    if (mangledName || cxaDemangled)
    102103        return DemangleEntry { mangledName, cxaDemangled };
     104#else
     105    UNUSED_PARAM(pc);
    103106#endif
    104107    return std::nullopt;

  • trunk/Source/WTF/wtf/generic/MemoryPressureHandlerGeneric.cpp

    r237099 r238836  
    4141}
    4242
    43 void MemoryPressureHandler::holdOff(Seconds seconds)
     43void MemoryPressureHandler::holdOff(Seconds)
    4444{
    4545}
    4646
    47 void MemoryPressureHandler::respondToMemoryPressure(Critical critical, Synchronous synchronous)
     47void MemoryPressureHandler::respondToMemoryPressure(Critical, Synchronous)
    4848{
    4949}

  • trunk/Source/WebCore/ChangeLog

    r238824 r238836  
     12018-12-03  Don Olmstead  <don.olmstead@sony.com>
     2
     3        Fix some unused parameter warnings
     4        https://bugs.webkit.org/show_bug.cgi?id=192336
     5
     6        Reviewed by Fujii Hironori.
     7
     8        * Modules/indexeddb/server/IDBSerialization.cpp:
     9        (WebCore::isLegacySerializedIDBKeyData):
     10        * platform/FileSystem.cpp:
     11        (WebCore::FileSystem::openAndLockFile):
     12        * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
     13        (WebCore::GraphicsContext3D::bindVertexArray):
     14        * platform/network/curl/CertificateInfo.h:
     15        (WTF::Persistence::Coder<WebCore::CertificateInfo>::encode):
     16        (WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):
     17
    1182018-12-03  Keith Rollin  <krollin@apple.com>
    219

  • trunk/Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp

    r231337 r238836  
    115115    GRefPtr<GVariant> variant = g_variant_new_from_bytes(G_VARIANT_TYPE("a{sv}"), bytes.get(), FALSE);
    116116    return g_variant_is_normal_form(variant.get());
     117#else
     118    UNUSED_PARAM(data);
     119    UNUSED_PARAM(size);
    117120#endif
    118121    return false;

  • trunk/Source/WebCore/platform/FileSystem.cpp

    r238802 r238836  
    340340    bool locked = lockFile(handle, lockMode);
    341341    ASSERT_UNUSED(locked, locked);
     342#else
     343    UNUSED_PARAM(lockMode);
    342344#endif
    343345

  • trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp

    r237266 r238836  
    15801580#if (!USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))) || PLATFORM(COCOA)
    15811581    ::glBindVertexArray(array);
     1582#else
     1583    UNUSED_PARAM(array);
    15821584#endif
    15831585}

  • trunk/Source/WebCore/platform/network/curl/CertificateInfo.h

    r238390 r238836  
    7272
    7373template<> struct Coder<WebCore::CertificateInfo> {
    74     static void encode(Encoder& encoder, const WebCore::CertificateInfo& certificateInfo)
     74    static void encode(Encoder&, const WebCore::CertificateInfo&)
    7575    {
    7676        notImplemented();
    7777    }
    7878
    79     static bool decode(Decoder& decoder, WebCore::CertificateInfo& certificateInfo)
     79    static bool decode(Decoder&, WebCore::CertificateInfo&)
    8080    {
    8181        notImplemented();
Note: See TracChangeset for help on using the changeset viewer.