Changeset 238843 in webkit

Timestamp:

Dec 3, 2018 10:01:16 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Audit: save the expanded state of test groups
​https://bugs.webkit.org/show_bug.cgi?id=192346
<rdar://problem/46440704>

Reviewed by Matt Baker.

• UserInterface/Views/AuditTreeElement.js:

(WI.AuditTreeElement):
(WI.AuditTreeElement.prototype.onattach):
(WI.AuditTreeElement.prototype.onexpand): Added.
(WI.AuditTreeElement.prototype.oncollapse): Added.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/AuditTreeElement.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-12-03  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Audit: save the expanded state of test groups
+        https://bugs.webkit.org/show_bug.cgi?id=192346
+        <rdar://problem/46440704>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/AuditTreeElement.js:
+        (WI.AuditTreeElement):
+        (WI.AuditTreeElement.prototype.onattach):
+        (WI.AuditTreeElement.prototype.onexpand): Added.
+        (WI.AuditTreeElement.prototype.oncollapse): Added.
+
 2018-12-03  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js

@@ -50 +50 @@
         const subtitle = null;
         super(classNames, representedObject.name, subtitle, representedObject, options);
+
+        if (isTestGroup)
+            this._expandedSetting = new WI.Setting(`audit-tree-element-${this.representedObject.name}-expanded`, false);
     }
 
@@ -66 +69 @@
                 this.representedObject.addEventListener(WI.AuditTestBase.Event.Scheduled, this._handleTestGroupScheduled, this);
         }
+
+        if (this._expandedSetting && this._expandedSetting.value)
+            this.expand();
 
         this._updateLevel();
@@ -95 +101 @@
                 this.appendChild(new WI.AuditTreeElement(result));
         }
+    }
+
+    onexpand()
+    {
+        console.assert(this.expanded);
+
+        if (this._expandedSetting)
+            this._expandedSetting.value = this.expanded;
+    }
+
+    oncollapse()
+    {
+        console.assert(!this.expanded);
+
+        if (this._expandedSetting)
+            this._expandedSetting.value = this.expanded;
     }