Changeset 239097 in webkit

Timestamp:

Dec 11, 2018 9:18:42 PM (5 years ago)

Author:

Fujii Hironori

Message:

[Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
​https://bugs.webkit.org/show_bug.cgi?id=192581

Reviewed by Alex Christensen.

Conventionally, WebKit COM interface adds a new interface with
same name methods with the old interface. For example, both
IWebEditingDelegate and IWebEditingDelegate2 interfaces has
shouldInsertNode method.

This is a part of public API, can't be renamed.

• PlatformWin.cmake: Added -Wno-overloaded-virtual compiler option

for WebKitLegacy

Location:

trunk/Source/WebKitLegacy

Files:

• ChangeLog (modified) (1 diff)
• PlatformWin.cmake (modified) (1 diff)

trunk/Source/WebKitLegacy/ChangeLog

@@ +1 @@
+2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
+        https://bugs.webkit.org/show_bug.cgi?id=192581
+
+        Reviewed by Alex Christensen.
+
+        Conventionally, WebKit COM interface adds a new interface with
+        same name methods with the old interface. For example, both
+        IWebEditingDelegate and IWebEditingDelegate2 interfaces has
+        shouldInsertNode method.
+
+        This is a part of public API, can't be renamed.
+
+        * PlatformWin.cmake: Added -Wno-overloaded-virtual compiler option
+        for WebKitLegacy
+
 2018-12-06  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKitLegacy/PlatformWin.cmake

@@ -276 +276 @@
         )
     endif ()
+endif ()
+
+if (COMPILER_IS_GCC_OR_CLANG)
+    WEBKIT_ADD_TARGET_CXX_FLAGS(WebKitLegacy -Wno-overloaded-virtual)
 endif ()