Changeset 239150 in webkit

Timestamp:

Dec 12, 2018 8:46:25 PM (5 years ago)

Author:

Simon Fraser

Message:

REGRESSION (r238090): CAPCHA UI jumps to the wrong location
​https://bugs.webkit.org/show_bug.cgi?id=192651
rdar://problem/46531919

Reviewed by Zalan Bujtas.

Source/WebCore:

When a RenderLayer becomes non-composited because of a style change, we need to set a dirty
bit to say that descendants need their geometry updated (because they now have to
compute their positions relative to a different ancestor). This wasn't happening
in the layerStyleChanged() code path.

In the code path that did do this correctly (in the computeCompositingRequirements() tree walk),
we can address a FIXME and only dirty direct children, not all descendants (that code was
written before the child-only dirty bit existed).

Test: compositing/geometry/update-child-geometry-on-compositing-change.html

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::layerStyleChanged):

LayoutTests:

Testcase that makes an intermediate layer non-composited (but still a RenderLayer).

• compositing/geometry/update-child-geometry-on-compositing-change-expected.html: Added.
• compositing/geometry/update-child-geometry-on-compositing-change.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/geometry/update-child-geometry-on-compositing-change-expected.html (added)
• LayoutTests/compositing/geometry/update-child-geometry-on-compositing-change.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerCompositor.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-12-12  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r238090): CAPCHA UI jumps to the wrong location
+        https://bugs.webkit.org/show_bug.cgi?id=192651
+        rdar://problem/46531919
+
+        Reviewed by Zalan Bujtas.
+        
+        Testcase that makes an intermediate layer non-composited (but still a RenderLayer).
+
+        * compositing/geometry/update-child-geometry-on-compositing-change-expected.html: Added.
+        * compositing/geometry/update-child-geometry-on-compositing-change.html: Added.
+
 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-12-12  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r238090): CAPCHA UI jumps to the wrong location
+        https://bugs.webkit.org/show_bug.cgi?id=192651
+        rdar://problem/46531919
+
+        Reviewed by Zalan Bujtas.
+        
+        When a RenderLayer becomes non-composited because of a style change, we need to set a dirty
+        bit to say that descendants need their geometry updated (because they now have to
+        compute their positions relative to a different ancestor). This wasn't happening
+        in the layerStyleChanged() code path.
+        
+        In the code path that did do this correctly (in the computeCompositingRequirements() tree walk),
+        we can address a FIXME and only dirty direct children, not all descendants (that code was
+        written before the child-only dirty bit existed).
+
+        Test: compositing/geometry/update-child-geometry-on-compositing-change.html
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+        (WebCore::RenderLayerCompositor::layerStyleChanged):
+
 2018-12-13  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -987 +987 @@
     if (updateBacking(layer, queryData, CompositingChangeRepaintNow, willBeComposited ? BackingRequired::Yes : BackingRequired::No)) {
         layer.setNeedsCompositingLayerConnection();
-        // Child layers need to get a geometry update to recompute their position. FIXME: Ideally we'd only dirty direct children.
-        layer.setDescendantsNeedUpdateBackingAndHierarchyTraversal();
+        // Child layers need to get a geometry update to recompute their position.
+        layer.setChildrenNeedCompositingGeometryUpdate();
         // The composited bounds of enclosing layers depends on which descendants are composited, so they need a geometry update.
         layer.setNeedsCompositingGeometryUpdateOnAncestors();
@@ -1380 +1380 @@
     bool layerChanged = updateBacking(layer, queryData, CompositingChangeRepaintNow);
     if (layerChanged) {
+        layer.setChildrenNeedCompositingGeometryUpdate();
         layer.setNeedsCompositingLayerConnection();
         layer.setSubsequentLayersNeedCompositingRequirementsTraversal();