Changeset 239197 in webkit

Timestamp:

Dec 13, 2018 8:39:11 PM (5 years ago)

Author:

Chris Dumez

Message:

[iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
​https://bugs.webkit.org/show_bug.cgi?id=192689
<rdar://problem/46323610>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-13
Reviewed by Simon Fraser.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

• UIProcess/WebPageProxy.h:

Don't wait until ~WebPageProxy to destroy the WebPageProxyDebuggable
which broadcasts it as a remote inspector target. Terminate this
as soon as the WebPageProxy closes and becomes invalid.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Platform/cocoa/WKCrashReporter.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ -13 +13 @@
         which broadcasts it as a remote inspector target. Terminate this
         as soon as the WebPageProxy closes and becomes invalid.
+
+2018-12-13  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed build fix for tvOS.
+
+        * Platform/cocoa/WKCrashReporter.mm:
 
 2018-12-13  Chris Dumez  <cdumez@apple.com>

trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm

@@ -31 +31 @@
 
 // Avoid having to link with libCrashReporterClient.a
-#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(TVOS) && __TV_OS_VERSION_MIN_REQUIRED >= 130000)
+#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 130000)
 CRASH_REPORTER_CLIENT_HIDDEN
 struct crashreporter_annotations_t gCRAnnotations