Changeset 239211 in webkit

Timestamp:

Dec 14, 2018 9:44:47 AM (5 years ago)

Author:

youenn@apple.com

Message:

IDB should store RTCCertificate
​https://bugs.webkit.org/show_bug.cgi?id=192599

Reviewed by Brady Eidson.

Source/WebCore:

In case there is no script execution context, do not create a JS DOM wrapper for RTCCertificate.
Instead, create an empty object so that the deserialization can still succeed.
This should only impact IDB deserialization in the Network Process which does not need the actual JS DOM wrapper.

Test: webrtc/certificates-indexeddb.html

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readTerminal):

LayoutTests:

• webrtc/certificates-indexeddb-expected.txt: Added.
• webrtc/certificates-indexeddb.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webrtc/certificates-indexeddb-expected.txt (added)
• LayoutTests/webrtc/certificates-indexeddb.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/js/SerializedScriptValue.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-12-14  Youenn Fablet  <youenn@apple.com>
+
+        IDB should store RTCCertificate
+        https://bugs.webkit.org/show_bug.cgi?id=192599
+
+        Reviewed by Brady Eidson.
+
+        * webrtc/certificates-indexeddb-expected.txt: Added.
+        * webrtc/certificates-indexeddb.html: Added.
+
 2018-12-13  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-12-14  Youenn Fablet  <youenn@apple.com>
+
+        IDB should store RTCCertificate
+        https://bugs.webkit.org/show_bug.cgi?id=192599
+
+        Reviewed by Brady Eidson.
+
+        In case there is no script execution context, do not create a JS DOM wrapper for RTCCertificate.
+        Instead, create an empty object so that the deserialization can still succeed.
+        This should only impact IDB deserialization in the Network Process which does not need the actual JS DOM wrapper.
+
+        Test: webrtc/certificates-indexeddb.html
+
+        * bindings/js/SerializedScriptValue.cpp:
+        (WebCore::CloneDeserializer::readTerminal):
+
 2018-12-14  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp

@@ -2718 +2718 @@
         }
 
+        if (!m_isDOMGlobalObject)
+            return constructEmptyObject(m_exec, m_globalObject->objectPrototype());
+
         auto rtcCertificate = RTCCertificate::create(SecurityOrigin::createFromString(origin->string()), expires, WTFMove(fingerprints), certificate->takeString(), keyedMaterial->takeString());
         return toJSNewlyCreated(m_exec, jsCast<JSDOMGlobalObject*>(m_globalObject), WTFMove(rtcCertificate));