Changeset 239221 in webkit

Timestamp:

Dec 14, 2018 10:26:47 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Prefer "about:blank" instead of an empty string for WebPageDebuggable url
​https://bugs.webkit.org/show_bug.cgi?id=192691
<rdar://problem/46719798>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-14
Reviewed by Darin Adler.

• UIProcess/WebPageDebuggable.cpp:

(WebKit::WebPageDebuggable::url const):
Instead of an empty string, return "about:blank" in bail cases.
When inspecting the page that matches the contents.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageDebuggable.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-12-14  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Prefer "about:blank" instead of an empty string for WebPageDebuggable url
+        https://bugs.webkit.org/show_bug.cgi?id=192691
+        <rdar://problem/46719798>
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/WebPageDebuggable.cpp:
+        (WebKit::WebPageDebuggable::url const):
+        Instead of an empty string, return "about:blank" in bail cases.
+        When inspecting the page that matches the contents.
+
 2018-12-14  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageDebuggable.cpp

@@ -56 +56 @@
 {
     if (!m_page.mainFrame())
-        return String();
+        return "about:blank"_s;
 
     String url = m_page.mainFrame()->url().string();
-    return url.isEmpty() ? "about:blank"_s : url;
+    if (url.isEmpty())
+        return "about:blank"_s;
+
+    return url;
 }