Changeset 239232 in webkit

Timestamp:

Dec 14, 2018 1:50:47 PM (5 years ago)

Author:

ddkilzer@apple.com

Message:

clang-tidy: Fix unnecessary copy of AtomicString each time one is logged
<​https://webkit.org/b/192710>
<rdar://problem/46738962>

Reviewed by Eric Carlson.

• wtf/Logger.h:

(WTF::LogArgument::toString): Make argument a const reference to
avoid the copy.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Logger.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-12-14  David Kilzer  <ddkilzer@apple.com>
+
+        clang-tidy: Fix unnecessary copy of AtomicString each time one is logged
+        <https://webkit.org/b/192710>
+        <rdar://problem/46738962>
+
+        Reviewed by Eric Carlson.
+
+        * wtf/Logger.h:
+        (WTF::LogArgument::toString): Make argument a const reference to
+        avoid the copy.
+
 2018-12-14  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WTF/wtf/Logger.h

@@ -45 +45 @@
     template<typename U = T> static typename std::enable_if<std::is_same<U, float>::value, String>::type toString(float argument) { return String::number(argument); }
     template<typename U = T> static typename std::enable_if<std::is_same<U, double>::value, String>::type toString(double argument) { return String::number(argument); }
-    template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, AtomicString>::value, String>::type toString(AtomicString argument) { return argument.string(); }
+    template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, AtomicString>::value, String>::type toString(const AtomicString& argument) { return argument.string(); }
     template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, String>::value, String>::type toString(String argument) { return argument; }
     template<typename U = T> static typename std::enable_if<std::is_same<typename std::remove_reference<U>::type, StringBuilder*>::value, String>::type toString(StringBuilder* argument) { return argument->toString(); }