Changeset 239235 in webkit
- Timestamp:
- Dec 14, 2018 2:49:07 PM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r239229 r239235 1 2018-12-14 Jiewen Tan <jiewen_tan@apple.com> 2 3 [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky 4 https://bugs.webkit.org/show_bug.cgi?id=192061 5 6 Reviewed by Dewei Zhu. 7 8 Part 2. 9 10 Add some additional temporary logging info. Since the failure cannot be reproduced easily by human, we have to 11 rely on the test infrastructure to reporoduce it. Once the bug is determined and fixed, we should remove all 12 logging added in this patch. 13 14 * UIProcess/WebAuthentication/Cocoa/HidService.mm: 15 (WebKit::HidService::deviceAdded): 16 * UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp: 17 (WebKit::CtapHidAuthenticator::makeCredential): 18 (WebKit::CtapHidAuthenticator::getAssertion): 19 * UIProcess/WebAuthentication/fido/CtapHidDriver.cpp: 20 (WebKit::CtapHidDriver::Worker::write): 21 (WebKit::CtapHidDriver::Worker::read): 22 (WebKit::CtapHidDriver::Worker::returnMessage): 23 (WebKit::CtapHidDriver::transact): 24 (WebKit::CtapHidDriver::continueAfterChannelAllocated): 25 (WebKit::CtapHidDriver::continueAfterResponseReceived): 26 1 27 2018-12-14 Adrian Perez de Castro <aperez@igalia.com> 2 28 -
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm
r238919 r239235 94 94 auto driver = std::make_unique<CtapHidDriver>(createHidConnection(device)); 95 95 // Get authenticator info from the device. 96 // FIXME(192061) 97 LOG_ERROR("Start asking device info."); 96 98 driver->transact(encodeEmptyAuthenticatorRequest(CtapRequestCommand::kAuthenticatorGetInfo), [weakThis = makeWeakPtr(*this), ptr = driver.get()](Vector<uint8_t>&& response) { 97 99 ASSERT(RunLoop::isMain()); -
trunk/Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp
r238166 r239235 50 50 void CtapHidAuthenticator::makeCredential() 51 51 { 52 // FIXME(192061) 53 LOG_ERROR("Start making credentials."); 52 54 auto cborCmd = encodeMakeCredenitalRequestAsCBOR(requestData().hash, requestData().creationOptions, m_info.options().userVerificationAvailability()); 53 55 m_driver->transact(WTFMove(cborCmd), [weakThis = makeWeakPtr(*this)](Vector<uint8_t>&& data) { … … 71 73 void CtapHidAuthenticator::getAssertion() 72 74 { 75 // FIXME(192061) 76 LOG_ERROR("Start getting assertions."); 73 77 auto cborCmd = encodeGetAssertionRequestAsCBOR(requestData().hash, requestData().requestOptions, m_info.options().userVerificationAvailability()); 74 78 m_driver->transact(WTFMove(cborCmd), [weakThis = makeWeakPtr(*this)](Vector<uint8_t>&& data) { -
trunk/Source/WebKit/UIProcess/WebAuthentication/fido/CtapHidDriver.cpp
r238246 r239235 70 70 { 71 71 ASSERT(m_state == State::Write); 72 // FIXME(192061) 73 LOG_ERROR("Start writing data."); 72 74 if (sent != HidConnection::DataSent::Yes) { 73 75 returnMessage(std::nullopt); … … 97 99 { 98 100 ASSERT(m_state == State::Read); 101 // FIXME(192061) 102 LOG_ERROR("Start reading data."); 99 103 if (!m_responseMessage) { 100 104 m_responseMessage = FidoHidMessage::createFromSerializedData(data); … … 127 131 void CtapHidDriver::Worker::returnMessage(std::optional<fido::FidoHidMessage>&& message) 128 132 { 133 // FIXME(192061) 134 LOG_ERROR("Start returning data."); 129 135 m_state = State::Idle; 130 136 m_connection->unregisterDataReceivedCallback(); … … 147 153 148 154 // Allocate a channel. 155 // FIXME(192061) 156 LOG_ERROR("Start allocating a channel."); 149 157 ASSERT(m_nonce.size() == kHidInitNonceLength); 150 158 cryptographicallyRandomValues(m_nonce.data(), m_nonce.size()); … … 188 196 m_channelId |= static_cast<uint32_t>(payload[index]); 189 197 // FIXME(191534): Check the reset of the payload. 198 // FIXME(192061) 199 LOG_ERROR("Start sending the request."); 190 200 auto cmd = FidoHidMessage::create(m_channelId, FidoHidDeviceCommand::kCbor, m_requestData); 191 201 ASSERT(cmd); … … 202 212 ASSERT(m_state == State::Ready); 203 213 ASSERT(!message || message->channelId() == m_channelId); 214 // FIXME(192061) 215 LOG_ERROR("Start returning the response."); 204 216 returnResponse(message ? message->getMessagePayload() : Vector<uint8_t>()); 205 217 }
Note: See TracChangeset
for help on using the changeset viewer.