Changeset 239237 in webkit

Timestamp:

Dec 14, 2018 3:23:10 PM (5 years ago)

Author:

ddkilzer@apple.com

Message:

clang-tidy: Fix unnecessary copy of objects for operator==() methods
<​https://webkit.org/b/192712>
<rdar://problem/46739332>

Reviewed by Andy Estes.

Source/JavaScriptCore:

• b3/air/AirAllocateRegistersByGraphColoring.cpp:

(JSC::B3::Air::(anonymous namespace)::AbstractColoringAllocator::InterferenceEdge::operator==):

• Change argument from const to const reference to avoid a copy.

Source/WebCore:

• contentextensions/HashableActionList.h:

(WebCore::ContentExtensions::HashableActionList::operator== const):
(WebCore::ContentExtensions::HashableActionList::operator!= const):

• platform/network/FormData.h:

(WebCore::FormDataElement::EncodedFileData::operator== const):
(WebCore::FormDataElement::EncodedBlobData::operator== const):

• Change arguments from const to const reference to avoid copies.

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/contentextensions/HashableActionList.h (modified) (1 diff)
• WebCore/platform/network/FormData.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-12-14  David Kilzer  <ddkilzer@apple.com>
+
+        clang-tidy: Fix unnecessary copy of objects for operator==() methods
+        <https://webkit.org/b/192712>
+        <rdar://problem/46739332>
+
+        Reviewed by Andy Estes.
+
+        * b3/air/AirAllocateRegistersByGraphColoring.cpp:
+        (JSC::B3::Air::(anonymous namespace)::AbstractColoringAllocator::InterferenceEdge::operator==):
+        - Change argument from const to const reference to avoid a copy.
+
 2018-12-14  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp

@@ -467 +467 @@
         }
 
-        bool operator==(const InterferenceEdge other) const
+        bool operator==(const InterferenceEdge& other) const
         {
             return m_value == other.m_value;

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-12-14  David Kilzer  <ddkilzer@apple.com>
+
+        clang-tidy: Fix unnecessary copy of objects for operator==() methods
+        <https://webkit.org/b/192712>
+        <rdar://problem/46739332>
+
+        Reviewed by Andy Estes.
+
+        * contentextensions/HashableActionList.h:
+        (WebCore::ContentExtensions::HashableActionList::operator== const):
+        (WebCore::ContentExtensions::HashableActionList::operator!= const):
+        * platform/network/FormData.h:
+        (WebCore::FormDataElement::EncodedFileData::operator== const):
+        (WebCore::FormDataElement::EncodedBlobData::operator== const):
+        - Change arguments from const to const reference to avoid
+          copies.
+
 2018-12-14  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/contentextensions/HashableActionList.h

@@ -54 +54 @@
     bool isDeletedValue() const { return state == Deleted; }
 
-    bool operator==(const HashableActionList other) const
+    bool operator==(const HashableActionList& other) const
     {
         return state == other.state && actions == other.actions;
     }
 
-    bool operator!=(const HashableActionList other) const
+    bool operator!=(const HashableActionList& other) const
     {
         return !(*this == other);

trunk/Source/WebCore/platform/network/FormData.h

@@ -86 +86 @@
         }
         
-        bool operator==(const EncodedFileData other) const
+        bool operator==(const EncodedFileData& other) const
         {
             return filename == other.filename
@@ -150 +150 @@
         URL url;
 
-        bool operator==(const EncodedBlobData other) const
+        bool operator==(const EncodedBlobData& other) const
         {
             return url == other.url;