Changeset 239240 in webkit

Timestamp:

Dec 14, 2018 4:06:15 PM (5 years ago)

Author:

youenn@apple.com

Message:

kVTVideoEncoderSpecification_Usage should not be set if VCP is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=192716

Reviewed by Eric Carlson.

​https://trac.webkit.org/changeset/239220 sets the usage value for all platforms, but we should only enable it for VCP.

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

(-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):

Location:

trunk/Source/ThirdParty/libwebrtc

Files:

• ChangeLog (modified) (1 diff)
• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (modified) (1 diff)

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2018-12-14  Youenn Fablet  <youenn@apple.com>
+
+        kVTVideoEncoderSpecification_Usage should not be set if VCP is not enabled
+        https://bugs.webkit.org/show_bug.cgi?id=192716
+
+        Reviewed by Eric Carlson.
+
+        https://trac.webkit.org/changeset/239220 sets the usage value for all platforms, but we should only enable it for VCP.
+        * Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+        (-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
+
 2018-12-14  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm

@@ -619 +619 @@
   CFDictionarySetValue(encoderSpecs, kVTCompressionPropertyKey_RealTime, kCFBooleanTrue);
 
-  if (auto key = getkVTVideoEncoderSpecification_Usage()) {
-    int usageValue = 1;
-    auto usage = CFNumberCreate(nullptr, kCFNumberIntType, &usageValue);
-    CFDictionarySetValue(encoderSpecs, (__bridge CFStringRef)key, usage);
-    CFRelease(usage);
-  }
-
+#if ENABLE_VCP_ENCODER
+  auto key = getkVTVideoEncoderSpecification_Usage();
+  int usageValue = 1;
+  auto usage = CFNumberCreate(nullptr, kCFNumberIntType, &usageValue);
+  CFDictionarySetValue(encoderSpecs, (__bridge CFStringRef)key, usage);
+  CFRelease(usage);
+#endif
   OSStatus status =
       CompressionSessionCreate(nullptr,  // use default allocator