Changeset 239255 in webkit
- Timestamp:
- Dec 15, 2018 4:21:25 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 32 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r239254 r239255 1 2018-12-15 Darin Adler <darin@apple.com> 2 3 Use warning-ignoring macros more consistently and simply 4 https://bugs.webkit.org/show_bug.cgi?id=192743 5 6 Reviewed by Mark Lam. 7 8 * dfg/DFGSpeculativeJIT64.cpp: Use IGNORE_WARNINGS_BEGIN/END instead of 9 IGNORE_CLANG_WARNINGS_BEGIN/END. Other callsites are using the non-clang-specific 10 one for this warning, "implicit-fallthrough", and it seems there is no special 11 need to use the clang-specific one here. 12 * llint/LLIntData.cpp: Ditto, but here it's "missing-noreturn"." 13 * tools/CodeProfiling.cpp: Ditto. 14 1 15 2018-12-15 Darin Adler <darin@apple.com> 2 16 -
trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
r239231 r239255 877 877 // Clang should allow unreachable [[clang::fallthrough]] in template functions if any template expansion uses it 878 878 // http://llvm.org/bugs/show_bug.cgi?id=18619 879 IGNORE_ CLANG_WARNINGS_BEGIN("implicit-fallthrough")879 IGNORE_WARNINGS_BEGIN("implicit-fallthrough") 880 880 template<bool strict> 881 881 GPRReg SpeculativeJIT::fillSpeculateInt32Internal(Edge edge, DataFormat& returnFormat) … … 1008 1008 } 1009 1009 } 1010 IGNORE_ CLANG_WARNINGS_END1010 IGNORE_WARNINGS_END 1011 1011 1012 1012 GPRReg SpeculativeJIT::fillSpeculateInt32(Edge edge, DataFormat& returnFormat) -
trunk/Source/JavaScriptCore/llint/LLIntData.cpp
r238414 r239255 75 75 } 76 76 77 IGNORE_ CLANG_WARNINGS_BEGIN("missing-noreturn")77 IGNORE_WARNINGS_BEGIN("missing-noreturn") 78 78 void Data::performAssertions(VM& vm) 79 79 { … … 185 185 } 186 186 } 187 IGNORE_ CLANG_WARNINGS_END187 IGNORE_WARNINGS_END 188 188 189 189 } } // namespace JSC::LLInt -
trunk/Source/JavaScriptCore/tools/CodeProfiling.cpp
r235935 r239255 45 45 WTF::MetaAllocatorTracker* CodeProfiling::s_tracker = 0; 46 46 47 IGNORE_ CLANG_WARNINGS_BEGIN("missing-noreturn")47 IGNORE_WARNINGS_BEGIN("missing-noreturn") 48 48 49 49 #if HAVE(MACHINE_CONTEXT) … … 61 61 #endif 62 62 63 IGNORE_ CLANG_WARNINGS_END63 IGNORE_WARNINGS_END 64 64 65 65 #if HAVE(MACHINE_CONTEXT) -
trunk/Source/WTF/ChangeLog
r239254 r239255 1 2018-12-15 Darin Adler <darin@apple.com> 2 3 Use warning-ignoring macros more consistently and simply 4 https://bugs.webkit.org/show_bug.cgi?id=192743 5 6 Reviewed by Mark Lam. 7 8 * wtf/Assertions.h: Use IGNORE_WARNINGS_BEGIN rather than 9 IGNORE_CLANG_WARNINGS_BEGIN since we don't need special handling for 10 non-clang compilers, in part since the code is already inside 11 #if COMPILER(CLANG), but also because it would be harmless to ignore this 12 warning on non-clang; we should almost never use IGNORE_CLANG_WARNINGS_BEGIN. 13 1 14 2018-12-15 Darin Adler <darin@apple.com> 2 15 -
trunk/Source/WTF/wtf/Assertions.h
r239012 r239255 611 611 // This would be a macro except that its use of #pragma works best around 612 612 // a function. Hence it uses macro naming convention. 613 IGNORE_ CLANG_WARNINGS_BEGIN("missing-noreturn")613 IGNORE_WARNINGS_BEGIN("missing-noreturn") 614 614 static inline void UNREACHABLE_FOR_PLATFORM() 615 615 { … … 618 618 RELEASE_ASSERT_NOT_REACHED(); 619 619 } 620 IGNORE_ CLANG_WARNINGS_END620 IGNORE_WARNINGS_END 621 621 #else 622 622 #define UNREACHABLE_FOR_PLATFORM() RELEASE_ASSERT_NOT_REACHED() -
trunk/Source/WebCore/ChangeLog
r239254 r239255 1 2018-12-15 Darin Adler <darin@apple.com> 2 3 Use warning-ignoring macros more consistently and simply 4 https://bugs.webkit.org/show_bug.cgi?id=192743 5 6 Reviewed by Mark Lam. 7 8 * bridge/objc/WebScriptObject.mm: Use IGNORE_WARNINGS_BEGIN rather than 9 IGNORE_CLANG_WARNINGS_BEGIN here. There is no need to compile Objective-C++ 10 files like this one with non-clang compilers, and no need to worry about 11 them when choosing the macro. 12 13 * crypto/mac/CryptoKeyRSAMac.cpp: 14 (WebCore::getPublicKeyComponents): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END. 15 16 * css/makeprop.pl: Use IGNORE_WARNINGS_BEGIN/END, obviating the need for 17 the "unknown-pragmas" trick, which the macro should take care of. 18 * css/makevalues.pl: Ditto. 19 * platform/ColorData.gperf: Ditto. 20 21 * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm: 22 (WebCore::CDMSessionAVStreamSession::update): Use IGNORE_WARNINGS_BEGIN/END 23 (see rationale above for Objective-C++). 24 25 * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: 26 (WebCore::MediaPlayerPrivateAVFoundationObjC::videoPlaybackQualityMetrics): Use 27 ALLOW_NEW_API_WITHOUT_GUARDS_BEGIN/END. 28 * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: 29 (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::videoPlaybackQualityMetrics): Ditto. 30 31 * platform/ios/DragImageIOS.mm: Use IGNORE_WARNINGS_BEGIN/END 32 (see rationale above for Objective-C++). 33 34 * platform/ios/VideoFullscreenInterfaceAVKit.mm: 35 (-[WebAVPlayerViewController setWebKitOverrideRouteSharingPolicy:routingContextUID:]): 36 Use ALLOW_NEW_API_WITHOUT_GUARDS_BEGIN/END. 37 38 * platform/mac/WebPlaybackControlsManager.mm: Use IGNORE_WARNINGS_BEGIN/END 39 (see rationale above for Objective-C++). 40 41 * platform/network/cocoa/ResourceResponseCocoa.mm: 42 (WebCore::ResourceResponse::platformCertificateInfo const): Use 43 ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END. 44 1 45 2018-12-15 Darin Adler <darin@apple.com> 2 46 -
trunk/Source/WebCore/PAL/ChangeLog
r239254 r239255 1 2018-12-15 Darin Adler <darin@apple.com> 2 3 Use warning-ignoring macros more consistently and simply 4 https://bugs.webkit.org/show_bug.cgi?id=192743 5 6 Reviewed by Mark Lam. 7 8 * pal/spi/cocoa/AVKitSPI.h: Use IGNORE_WARNINGS_BEGIN instead of 9 IGNORE_CLANG_WARNINGS_BEGIN; there is no special need to accomodate 10 non-clang compilers here. 11 1 12 2018-12-15 Darin Adler <darin@apple.com> 2 13 -
trunk/Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h
r238560 r239255 39 39 40 40 #import <AVKit/AVPlayerController.h> 41 IGNORE_ CLANG_WARNINGS_BEGIN("objc-property-no-attribute")41 IGNORE_WARNINGS_BEGIN("objc-property-no-attribute") 42 42 #import <AVKit/AVPlayerLayerView.h> 43 IGNORE_ CLANG_WARNINGS_END43 IGNORE_WARNINGS_END 44 44 #import <AVKit/AVPlayerViewController_Private.h> 45 45 #import <AVKit/AVPlayerViewController_WebKitOnly.h> -
trunk/Source/WebCore/bridge/objc/WebScriptObject.mm
r235935 r239255 703 703 } 704 704 705 IGNORE_ CLANG_WARNINGS_BEGIN("objc-missing-super-calls")705 IGNORE_WARNINGS_BEGIN("objc-missing-super-calls") 706 706 - (void)dealloc 707 707 { 708 return;709 } 710 IGNORE_ CLANG_WARNINGS_END708 // Intentionally not calling [super dealloc] since we never want to deallocate our single instance. 709 } 710 IGNORE_WARNINGS_END 711 711 712 712 + (WebUndefined *)undefined -
trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp
r238754 r239255 63 63 ASSERT(CCRSAGetKeyType(rsaKey) == ccRSAKeyPublic || CCRSAGetKeyType(rsaKey) == ccRSAKeyPrivate); 64 64 bool keyIsPublic = CCRSAGetKeyType(rsaKey) == ccRSAKeyPublic; 65 #pragma clang diagnostic push 66 #pragma clang diagnostic ignored "-Wdeprecated-declarations" 65 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 67 66 CCRSACryptorRef publicKey = keyIsPublic ? rsaKey : CCRSACryptorGetPublicKeyFromPrivateKey(rsaKey); 68 #pragma clang diagnostic pop 67 ALLOW_DEPRECATED_DECLARATIONS_END 69 68 70 69 modulus.resize(16384); -
trunk/Source/WebCore/css/makeprop.pl
r238262 r239255 249 249 #include <string.h> 250 250 251 #if defined(__clang__) 252 #pragma clang diagnostic push 253 #pragma clang diagnostic ignored \"-Wunknown-pragmas\" 254 #pragma clang diagnostic ignored \"-Wimplicit-fallthrough\" 255 #endif 251 IGNORE_WARNINGS_BEGIN(\"implicit-fallthrough\") 256 252 257 253 // Older versions of gperf like to use the `register` keyword. … … 422 418 } // namespace WebCore 423 419 424 #if defined(__clang__) 425 #pragma clang diagnostic pop 426 #endif 420 IGNORE_WARNINGS_END 427 421 EOF 428 422 -
trunk/Source/WebCore/css/makevalues.pl
r236091 r239255 79 79 #include <string.h> 80 80 81 #if defined(__clang__) 82 #pragma clang diagnostic push 83 #pragma clang diagnostic ignored \"-Wunknown-pragmas\" 84 #pragma clang diagnostic ignored \"-Wimplicit-fallthrough\" 85 #endif 81 IGNORE_WARNINGS_BEGIN(\"implicit-fallthrough\") 86 82 87 83 // Older versions of gperf like to use the `register` keyword. … … 156 152 } // namespace WebCore 157 153 158 #if defined(__clang__) 159 #pragma clang diagnostic pop 160 #endif 154 IGNORE_WARNINGS_END 161 155 EOF 162 156 close GPERF; -
trunk/Source/WebCore/platform/ColorData.gperf
r231753 r239255 3 3 #include <string.h> 4 4 5 #if defined(__clang__) 6 #pragma clang diagnostic push 7 #pragma clang diagnostic ignored "-Wunknown-pragmas" 8 #pragma clang diagnostic ignored "-Wimplicit-fallthrough" 9 #endif 5 IGNORE_WARNINGS_BEGIN("implicit-fallthrough") 10 6 11 7 // Older versions of gperf like to use the `register` keyword. … … 185 181 } // namespace WebCore 186 182 187 #if defined(__clang__) 188 #pragma clang diagnostic pop 189 #endif 183 IGNORE_WARNINGS_END -
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm
r237009 r239255 199 199 RetainPtr<NSData> certificateData = adoptNS([[NSData alloc] initWithBytes:m_certificate->data() length:m_certificate->length()]); 200 200 201 IGNORE_ CLANG_WARNINGS_BEGIN("objc-literal-conversion")201 IGNORE_WARNINGS_BEGIN("objc-literal-conversion") 202 202 String storagePath = this->storagePath(); 203 203 if (!storagePath.isEmpty() && [getAVStreamSessionClass() respondsToSelector:@selector(removePendingExpiredSessionReports:withAppIdentifier:storageDirectoryAtURL:)]) 204 204 [getAVStreamSessionClass() removePendingExpiredSessionReports:@[m_expiredSession.get()] withAppIdentifier:certificateData.get() storageDirectoryAtURL:[NSURL fileURLWithPath:storagePath]]; 205 IGNORE_ CLANG_WARNINGS_END205 IGNORE_WARNINGS_END 206 206 m_expiredSession = nullptr; 207 207 return true; -
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
r239230 r239255 3273 3273 return std::nullopt; 3274 3274 #else 3275 #pragma clang diagnostic push 3276 #pragma clang diagnostic ignored "-Wunknown-pragmas" 3277 #pragma clang diagnostic ignored "-Wunguarded-availability-new" 3275 ALLOW_NEW_API_WITHOUT_GUARDS_BEGIN 3276 3278 3277 auto metrics = [m_videoLayer videoPerformanceMetrics]; 3279 3278 if (!metrics) … … 3291 3290 displayCompositedFrames, 3292 3291 }; 3293 #pragma clang diagnostic pop 3292 3293 ALLOW_NEW_API_WITHOUT_GUARDS_END 3294 3294 #endif 3295 3295 } -
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
r239230 r239255 658 658 659 659 uint32_t displayCompositedFrames = 0; 660 #pragma clang diagnostic push 661 #pragma clang diagnostic ignored "-Wunknown-pragmas" 662 #pragma clang diagnostic ignored "-Wunguarded-availability-new" 660 ALLOW_NEW_API_WITHOUT_GUARDS_BEGIN 663 661 if ([metrics respondsToSelector:@selector(numberOfDisplayCompositedVideoFrames)]) 664 662 displayCompositedFrames = [metrics numberOfDisplayCompositedVideoFrames]; 665 #pragma clang diagnostic pop 663 ALLOW_NEW_API_WITHOUT_GUARDS_END 666 664 667 665 return VideoPlaybackQualityMetrics { -
trunk/Source/WebCore/platform/ios/DragImageIOS.mm
r237266 r239255 53 53 #import <wtf/SoftLinking.h> 54 54 55 IGNORE_ CLANG_WARNINGS_BEGIN("nullability-completeness")55 IGNORE_WARNINGS_BEGIN("nullability-completeness") 56 56 57 57 SOFT_LINK_FRAMEWORK(UIKit) … … 63 63 SOFT_LINK(UIKit, UIGraphicsEndImageContext, void, (void), ()) 64 64 65 IGNORE_ CLANG_WARNINGS_END65 IGNORE_WARNINGS_END 66 66 67 67 namespace WebCore { -
trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
r238528 r239255 584 584 - (void)setWebKitOverrideRouteSharingPolicy:(NSUInteger)routeSharingPolicy routingContextUID:(NSString *)routingContextUID 585 585 { 586 #pragma clang diagnostic push 587 #pragma clang diagnostic ignored "-Wunknown-pragmas" 588 #pragma clang diagnostic ignored "-Wunguarded-availability-new" 586 ALLOW_NEW_API_WITHOUT_GUARDS_BEGIN 589 587 if ([_avPlayerViewController respondsToSelector:@selector(setWebKitOverrideRouteSharingPolicy:routingContextUID:)]) 590 588 [_avPlayerViewController setWebKitOverrideRouteSharingPolicy:routeSharingPolicy routingContextUID:routingContextUID]; 591 #pragma clang diagnostic pop 589 ALLOW_NEW_API_WITHOUT_GUARDS_END 592 590 } 593 591 -
trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm
r236748 r239255 35 35 #import <wtf/text/WTFString.h> 36 36 37 IGNORE_CLANG_WARNINGS_BEGIN("nullability-completeness") 37 IGNORE_WARNINGS_BEGIN("nullability-completeness") 38 38 39 SOFT_LINK_FRAMEWORK(AVKit) 39 40 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 … … 344 345 } 345 346 346 IGNORE_ CLANG_WARNINGS_END347 IGNORE_WARNINGS_END 347 348 348 349 @end 349 350 350 351 #endif // PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE) && ENABLE(WEB_PLAYBACK_CONTROLS_MANAGER) 351 -
trunk/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm
r238144 r239255 98 98 if (trustResultType == kSecTrustResultInvalid) { 99 99 // FIXME: This is deprecated <rdar://problem/45894288>. 100 #pragma clang diagnostic push 101 #pragma clang diagnostic ignored "-Wdeprecated-declarations" 100 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 102 101 result = SecTrustEvaluate(trust, &trustResultType); 103 #pragma clang diagnostic pop 102 ALLOW_DEPRECATED_DECLARATIONS_END 104 103 if (result != errSecSuccess) 105 104 return { }; -
trunk/Source/WebKit/ChangeLog
r239254 r239255 1 2018-12-15 Darin Adler <darin@apple.com> 2 3 Use warning-ignoring macros more consistently and simply 4 https://bugs.webkit.org/show_bug.cgi?id=192743 5 6 Reviewed by Mark Lam. 7 8 * UIProcess/ios/WKDrawingView.mm: 9 (-[WKDrawingView initWithEmbeddedViewID:webPageProxy:]): 10 Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END. 11 * UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: 12 (-[WKFullScreenWindowController _EVOrganizationName]): Ditto. 13 14 * WebProcess/WebCoreSupport/WebAlternativeTextClient.h: Use 15 IGNORE_WARNINGS_BEGIN/END instead of IGNORE_CLANG_WARNINGS_BEGIN/END 16 because there is no need to accomodate non-clang compilers here. 17 Also use #pragma once, add a missing "explicit", and fix conditionals. 18 1 19 2018-12-15 Darin Adler <darin@apple.com> 2 20 -
trunk/Source/WebKit/UIProcess/ios/WKDrawingView.mm
r239241 r239255 61 61 [_pencilView setUserInteractionEnabled:YES]; 62 62 [_pencilView setOpaque:NO]; 63 #pragma clang diagnostic push 64 #pragma clang diagnostic ignored "-Wdeprecated-declarations" 63 64 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 65 65 [_pencilView setDrawingDelegate:self]; 66 #pragma clang diagnostic pop 66 ALLOW_DEPRECATED_DECLARATIONS_END 67 67 68 68 [self addSubview:_pencilView.get()]; -
trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
r239128 r239255 908 908 909 909 // FIXME: This is deprecated <rdar://problem/45894288>. 910 #pragma clang diagnostic push 911 #pragma clang diagnostic ignored "-Wdeprecated-declarations" 910 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 912 911 OSStatus err = SecTrustEvaluate(trust, &result); 913 #pragma clang diagnostic pop 912 ALLOW_DEPRECATED_DECLARATIONS_END 914 913 915 914 if (err == noErr) -
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebAlternativeTextClient.h
r237266 r239255 24 24 */ 25 25 26 27 #ifndef WebAlternativeTextClient_h 28 #define WebAlternativeTextClient_h 26 #pragma once 29 27 30 28 #include <WebCore/AlternativeTextClient.h> … … 36 34 class WebAlternativeTextClient : public WebCore::AlternativeTextClient { 37 35 public: 38 WebAlternativeTextClient(WebPage*);36 explicit WebAlternativeTextClient(WebPage*); 39 37 virtual ~WebAlternativeTextClient(); 40 38 void pageDestroyed() override; … … 50 48 Vector<String> dictationAlternatives(uint64_t dictationContext) override; 51 49 #endif 50 52 51 private: 53 #if PLATFORM(IOS_FAMILY)54 IGNORE_ CLANG_WARNINGS_BEGIN("unused-private-field")52 #if !(USE(AUTOCORRECTION_PANEL) || USE(DICTATION_ALTERNATIVES)) 53 IGNORE_WARNINGS_BEGIN("unused-private-field") 55 54 #endif 56 WebPage *m_page;57 #if PLATFORM(IOS_FAMILY)58 IGNORE_ CLANG_WARNINGS_END55 WebPage* m_page; 56 #if !(USE(AUTOCORRECTION_PANEL) || USE(DICTATION_ALTERNATIVES)) 57 IGNORE_WARNINGS_END 59 58 #endif 60 59 }; 61 60 62 61 } 63 64 #endif // WebAlternativeTextClient_h -
trunk/Source/WebKitLegacy/mac/ChangeLog
r239149 r239255 1 2018-12-15 Darin Adler <darin@apple.com> 2 3 Use warning-ignoring macros more consistently and simply 4 https://bugs.webkit.org/show_bug.cgi?id=192743 5 6 Reviewed by Mark Lam. 7 8 * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of 9 IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang 10 compilers in Objective-C++ code. 11 12 * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END 13 instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to 14 accomodate non-clang compilers here. Also use #pragma once, add a missing 15 "explicit" and fix conditionals. 16 1 17 2018-12-12 Ryosuke Niwa <rniwa@webkit.org> 2 18 -
trunk/Source/WebKitLegacy/mac/DOM/DOM.mm
r237266 r239255 245 245 @implementation DOMNode (WebCoreInternal) 246 246 247 IGNORE_ CLANG_WARNINGS_BEGIN("objc-protocol-method-implementation")247 IGNORE_WARNINGS_BEGIN("objc-protocol-method-implementation") 248 248 249 249 - (NSString *)description … … 259 259 } 260 260 261 IGNORE_ CLANG_WARNINGS_END261 IGNORE_WARNINGS_END 262 262 263 263 - (Bindings::RootObject*)_rootObject -
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.h
r237266 r239255 24 24 */ 25 25 26 27 #ifndef WebAlternativeTextClient_h 28 #define WebAlternativeTextClient_h 26 #pragma once 29 27 30 28 #import "CorrectionPanel.h" … … 35 33 class WebAlternativeTextClient : public WebCore::AlternativeTextClient { 36 34 public: 37 WebAlternativeTextClient(WebView*);35 explicit WebAlternativeTextClient(WebView*); 38 36 virtual ~WebAlternativeTextClient(); 39 37 void pageDestroyed() override; … … 49 47 Vector<String> dictationAlternatives(uint64_t dictationContext) override; 50 48 #endif 49 51 50 private: 52 #if PLATFORM(IOS_FAMILY)53 IGNORE_CLANG_WARNINGS_BEGIN("unused-private-field")51 #if !(USE(AUTOCORRECTION_PANEL) || USE(DICTATION_ALTERNATIVES)) 52 IGNORE_WARNINGS_BEGIN("unused-private-field") 54 53 #endif 55 54 WebView* m_webView; 56 #if PLATFORM(IOS_FAMILY)57 IGNORE_CLANG_WARNINGS_END55 #if !(USE(AUTOCORRECTION_PANEL) || USE(DICTATION_ALTERNATIVES)) 56 IGNORE_WARNINGS_END 58 57 #endif 58 59 59 #if USE(AUTOCORRECTION_PANEL) 60 60 CorrectionPanel m_correctionPanel; 61 61 #endif 62 62 }; 63 64 #endif // WebAlternativeTextClient_h -
trunk/Tools/ChangeLog
r239254 r239255 1 2018-12-15 Darin Adler <darin@apple.com> 2 3 Use warning-ignoring macros more consistently and simply 4 https://bugs.webkit.org/show_bug.cgi?id=192743 5 6 Reviewed by Mark Lam. 7 8 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 9 (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END. 10 * DumpRenderTree/mac/TextInputControllerMac.m: 11 (-[TextInputController interpretKeyEvents:withSender:]): Use 12 IGNORE_WARNINGS_BEGIN/END. 13 * WebKitTestRunner/mac/EventSenderProxy.mm: 14 (WTR::EventSenderProxy::mouseForceClick): Use 15 IGNORE_NULL_CHECK_WARNINGS_BEGIN/END. 16 (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto. 17 (WTR::EventSenderProxy::mouseForceDown): Ditto. 18 (WTR::EventSenderProxy::mouseForceUp): Ditto. 19 (WTR::EventSenderProxy::mouseForceChanged): Ditto. 20 1 21 2018-12-15 Darin Adler <darin@apple.com> 2 22 -
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
r221609 r239255 472 472 case mouseDown: 473 473 if (obj->eventLogging) { 474 #if __clang__ 475 #pragma clang diagnostic push 476 #pragma clang diagnostic ignored "-Wdeprecated-declarations" 477 #endif 474 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 478 475 GlobalToLocal(&pt); 479 #if __clang__ 480 #pragma clang diagnostic pop 481 #endif 476 ALLOW_DEPRECATED_DECLARATIONS_END 482 477 pluginLog(instance, "mouseDown at (%d, %d)", pt.h, pt.v); 483 478 } … … 487 482 case mouseUp: 488 483 if (obj->eventLogging) { 489 #if __clang__ 490 #pragma clang diagnostic push 491 #pragma clang diagnostic ignored "-Wdeprecated-declarations" 492 #endif 484 ALLOW_DEPRECATED_DECLARATIONS_BEGIN 493 485 GlobalToLocal(&pt); 494 #if __clang__ 495 #pragma clang diagnostic pop 496 #endif 486 ALLOW_DEPRECATED_DECLARATIONS_END 497 487 pluginLog(instance, "mouseUp at (%d, %d)", pt.h, pt.v); 498 488 } -
trunk/Tools/DumpRenderTree/mac/TextInputControllerMac.m
r239149 r239255 542 542 id result = [inputMethodHandler callWebScriptMethod:@"call" withArguments:[NSArray arrayWithObjects:inputMethodHandler, eventParam, nil]]; 543 543 if (![result respondsToSelector:@selector(boolValue)] || ![result boolValue]) { 544 #pragma clang diagnostic push 545 #pragma clang diagnostic ignored "-Wundeclared-selector" 544 IGNORE_WARNINGS_BEGIN("undeclared-selector") 546 545 [sender doCommandBySelector:@selector(noop:)]; // AppKit sends noop: if the ime does not handle an event 547 #pragma clang diagnostic pop 546 IGNORE_WARNINGS_END 548 547 } 549 548 -
trunk/Tools/WebKitTestRunner/mac/EventSenderProxy.mm
r237405 r239255 418 418 419 419 [NSApp _setCurrentEvent:nil]; 420 #pragma clang diagnostic push421 #pragma clang diagnostic ignored "-Wnonnull"422 420 // WKView caches the most recent pressure event, so send it a nil event to clear the cache. 421 IGNORE_NULL_CHECK_WARNINGS_BEGIN 423 422 [targetView pressureChangeWithEvent:nil]; 424 #pragma clang diagnostic pop 423 IGNORE_NULL_CHECK_WARNINGS_END 425 424 } 426 425 … … 454 453 455 454 [NSApp _setCurrentEvent:nil]; 456 #pragma clang diagnostic push457 #pragma clang diagnostic ignored "-Wnonnull"458 455 // WKView caches the most recent pressure event, so send it a nil event to clear the cache. 456 IGNORE_NULL_CHECK_WARNINGS_BEGIN 459 457 [targetView pressureChangeWithEvent:nil]; 460 #pragma clang diagnostic pop 458 IGNORE_NULL_CHECK_WARNINGS_END 461 459 } 462 460 … … 480 478 481 479 [NSApp _setCurrentEvent:nil]; 482 #pragma clang diagnostic push483 #pragma clang diagnostic ignored "-Wnonnull"484 480 // WKView caches the most recent pressure event, so send it a nil event to clear the cache. 481 IGNORE_NULL_CHECK_WARNINGS_BEGIN 485 482 [targetView pressureChangeWithEvent:nil]; 486 #pragma clang diagnostic pop 483 IGNORE_NULL_CHECK_WARNINGS_END 487 484 } 488 485 … … 504 501 505 502 [NSApp _setCurrentEvent:nil]; 506 507 #pragma clang diagnostic push 508 #pragma clang diagnostic ignored "-Wnonnull" 509 // WKView caches the most recent pressure event, so send it a nil event to clear the cache. 503 // WKView caches the most recent pressure event, so send it a nil event to clear the cache. 504 IGNORE_NULL_CHECK_WARNINGS_BEGIN 510 505 [targetView pressureChangeWithEvent:nil]; 511 #pragma clang diagnostic pop 506 IGNORE_NULL_CHECK_WARNINGS_END 512 507 } 513 508 … … 526 521 [NSApp sendEvent:pressureChangedEvent.get()]; 527 522 528 #pragma clang diagnostic push529 #pragma clang diagnostic ignored "-Wnonnull"530 523 // WKView caches the most recent pressure event, so send it a nil event to clear the cache. 524 IGNORE_NULL_CHECK_WARNINGS_BEGIN 531 525 [targetView pressureChangeWithEvent:nil]; 532 #pragma clang diagnostic pop 526 IGNORE_NULL_CHECK_WARNINGS_END 533 527 } 534 528 #else
Note: See TracChangeset
for help on using the changeset viewer.