Changeset 239261 in webkit

Timestamp:

Dec 16, 2018 2:29:13 PM (5 years ago)

Author:

Adrian Perez de Castro

Message:

Unreviewed follow up after r239260
​https://bugs.webkit.org/show_bug.cgi?id=192714
<rdar://problem/46762407>

• Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::allocate): Use PAGE_READWRITE directly instead
of going through the protectAttribute() function, which is removed
because it is now unused.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Platform/win/SharedMemoryWin.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
+
+        Unreviewed follow up after r239260
+        https://bugs.webkit.org/show_bug.cgi?id=192714
+        <rdar://problem/46762407>
+
+        * Platform/win/SharedMemoryWin.cpp:
+        (WebKit::SharedMemory::allocate): Use PAGE_READWRITE directly instead
+        of going through the protectAttribute() function, which is removed
+        because it is now unused.
+
 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WebKit/Platform/win/SharedMemoryWin.cpp

@@ -118 +118 @@
 }
 
-static DWORD protectAttribute(SharedMemory::Protection protection)
-{
-    switch (protection) {
-    case SharedMemory::Protection::ReadOnly:
-        return PAGE_READONLY;
-    case SharedMemory::Protection::ReadWrite:
-        return PAGE_READWRITE;
-    }
-
-    ASSERT_NOT_REACHED();
-    return 0;
-}
-
 RefPtr<SharedMemory> SharedMemory::allocate(size_t size)
 {
-    HANDLE handle = ::CreateFileMappingW(INVALID_HANDLE_VALUE, 0, protectAttribute(SharedMemory::Protection::ReadWrite), 0, size, 0);
+    HANDLE handle = ::CreateFileMappingW(INVALID_HANDLE_VALUE, 0, PAGE_READWRITE, 0, size, 0);
     if (!handle)
         return nullptr;