Changeset 239323 in webkit


Ignore:
Timestamp:
Dec 17, 2018 10:37:28 PM (5 years ago)
Author:
jiewen_tan@apple.com
Message:

[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Source/WebKit:

Part 3.

Add some additional temporary logging info to determine if the timer is working as expected.
Once the bug is determined and fixed, we should remove all logging added in this patch.

  • UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::respondReceived):
(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::timeOutTimerFired):

  • UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:

(WebKit::MockAuthenticatorManager::respondReceivedInternal):

LayoutTests:

Add a time out value.

  • http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r239319 r239323  
     12018-12-17  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=192061
     5
     6        Reviewed by Dewei Zhu.
     7
     8        Add a time out value.
     9
     10        * http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
     11
    1122018-12-17  Eric Carlson  <eric.carlson@apple.com>
    213
  • trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html

    r238598 r239323  
    7070                challenge: Base64URL.parse("MTIzNDU2"),
    7171                pubKeyCredParams: [{ type: "public-key", alg: -7 }],
    72                 authenticatorSelection: { authenticatorAttachment: "cross-platform" }
     72                authenticatorSelection: { authenticatorAttachment: "cross-platform" },
     73                timeout: 10
    7374            }
    7475        };
  • trunk/Source/WebKit/ChangeLog

    r239322 r239323  
     12018-12-17  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=192061
     5
     6        Reviewed by Dewei Zhu.
     7
     8        Part 3.
     9
     10        Add some additional temporary logging info to determine if the timer is working as expected.
     11        Once the bug is determined and fixed, we should remove all logging added in this patch.
     12
     13        * UIProcess/WebAuthentication/AuthenticatorManager.cpp:
     14        (WebKit::AuthenticatorManager::respondReceived):
     15        (WebKit::AuthenticatorManager::initTimeOutTimer):
     16        (WebKit::AuthenticatorManager::timeOutTimerFired):
     17        * UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:
     18        (WebKit::MockAuthenticatorManager::respondReceivedInternal):
     19
    1202018-12-17  Saam barati  <sbarati@apple.com>
    221
  • trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp

    r238240 r239323  
    192192        m_pendingCompletionHandler(WTFMove(respond));
    193193        clearStateAsync();
     194        // FIXME(192061)
     195        LOG_ERROR("Stop timer.");
    194196        m_requestTimeOutTimer.stop();
    195197        return;
     
    224226
    225227    unsigned timeOutInMsValue = std::min(maxTimeOutValue, timeOutInMs.value_or(maxTimeOutValue));
     228    // FIXME(192061)
     229    LOG_ERROR("Start timer.");
    226230    m_requestTimeOutTimer.startOneShot(Seconds::fromMilliseconds(timeOutInMsValue));
    227231}
     
    229233void AuthenticatorManager::timeOutTimerFired()
    230234{
     235    ASSERT(m_requestTimeOutTimer.isActive());
     236    // FIXME(192061)
     237    LOG_ERROR("Timer fired.");
    231238    m_pendingCompletionHandler((ExceptionData { NotAllowedError, "Operation timed out."_s }));
    232239    clearStateAsync();
  • trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp

    r238166 r239323  
    4848    pendingCompletionHandler()(WTFMove(respond));
    4949    clearStateAsync();
     50    // FIXME(192061)
     51    LOG_ERROR("Stop timer.");
    5052    requestTimeOutTimer().stop();
    5153}
Note: See TracChangeset for help on using the changeset viewer.