Changeset 239337 in webkit

Timestamp:

Dec 18, 2018 7:37:10 AM (5 years ago)

Author:

Wenson Hsieh

Message:

Calling setValue() while typing should invoke -textDidChangeInTextField in the injected bundle
​https://bugs.webkit.org/show_bug.cgi?id=192785
<rdar://problem/45321184>

Reviewed by Tim Horton.

Source/WebCore:

Makes a minor adjustment in TextFieldInputType::setValue to consider value changes as "user editing", if we're
currently processing a keystroke from the user. This is useful for certain private clients, such as Safari, that
need to know when the user is typing in a text form control, but the page is preventing default text insertion
behavior and instead updating values programmatically.

Test: fast/forms/call-text-did-change-in-text-field-when-typing.html

• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue):

LayoutTests:

Add a test to verify that:

1. When typing in a focused field, the injected bundle method is invoked.
2. When changing the value of the focused field under non-typing user interaction, the method isn't invoked.
3. When changing the value of the focused field programmatically without user gesture, the method isn't invoked.

• TestExpectations:
• fast/forms/call-text-did-change-in-text-field-when-typing-expected.txt: Added.
• fast/forms/call-text-did-change-in-text-field-when-typing.html: Added.
• platform/wk2/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• LayoutTests/fast/forms/call-text-did-change-in-text-field-when-typing-expected.txt (added)
• LayoutTests/fast/forms/call-text-did-change-in-text-field-when-typing.html (added)
• LayoutTests/platform/wk2/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/TextFieldInputType.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Calling setValue() while typing should invoke -textDidChangeInTextField in the injected bundle
+        https://bugs.webkit.org/show_bug.cgi?id=192785
+        <rdar://problem/45321184>
+
+        Reviewed by Tim Horton.
+
+        Add a test to verify that:
+        1. When typing in a focused field, the injected bundle method is invoked.
+        2. When changing the value of the focused field under non-typing user interaction, the method isn't invoked.
+        3. When changing the value of the focused field programmatically without user gesture, the method isn't invoked.
+
+        * TestExpectations:
+        * fast/forms/call-text-did-change-in-text-field-when-typing-expected.txt: Added.
+        * fast/forms/call-text-did-change-in-text-field-when-typing.html: Added.
+        * platform/wk2/TestExpectations:
+
 2018-12-17  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -130 +130 @@
 http/tests/navigation/useragent-reload.php [ Skip ]
 storage/indexeddb/modern/opendatabase-after-storage-crash.html [ Skip ]
+fast/forms/call-text-did-change-in-text-field-when-typing.html [ Skip ]
 
 # Only Mac and iOS have an implementation of UIScriptController::doAsyncTask().

trunk/LayoutTests/platform/wk2/TestExpectations

@@ -743 +743 @@
 storage/indexeddb/modern/opendatabase-after-storage-crash.html [ Pass ]
 
+fast/forms/call-text-did-change-in-text-field-when-typing.html [ Pass ]
+
 ### END OF (5) Progressions, expected successes that are expected failures in WebKit1.
 ########################################

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Calling setValue() while typing should invoke -textDidChangeInTextField in the injected bundle
+        https://bugs.webkit.org/show_bug.cgi?id=192785
+        <rdar://problem/45321184>
+
+        Reviewed by Tim Horton.
+
+        Makes a minor adjustment in `TextFieldInputType::setValue` to consider value changes as "user editing", if we're
+        currently processing a keystroke from the user. This is useful for certain private clients, such as Safari, that
+        need to know when the user is typing in a text form control, but the page is preventing default text insertion
+        behavior and instead updating values programmatically.
+
+        Test: fast/forms/call-text-did-change-in-text-field-when-typing.html
+
+        * html/TextFieldInputType.cpp:
+        (WebCore::TextFieldInputType::setValue):
+
 2018-12-18  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/html/TextFieldInputType.cpp

@@ -58 +58 @@
 #include "TextIterator.h"
 #include "TextNodeTraversal.h"
+#include "UserTypingGestureIndicator.h"
 #include "WheelEvent.h"
 
@@ -169 +170 @@
     if (!input->focused() || eventBehavior == DispatchNoEvent)
         input->setTextAsOfLastFormControlChangeEvent(sanitizedValue);
+
+    if (UserTypingGestureIndicator::processingUserTypingGesture())
+        didSetValueByUserEdit();
 }