Changeset 239352 in webkit

Timestamp:

Dec 18, 2018 1:54:24 PM (5 years ago)

Author:

ddkilzer@apple.com

Message:

clang-tidy: Use const reference for MediaTime parameter to prevent object copy
<​https://webkit.org/b/192814>

Reviewed by Mark Lam.

Source/JavaScriptCore:

• runtime/JSCJSValue.h:

(JSC::jsNumber):

Source/WebCore:

• bindings/js/JSDOMConvertNumbers.h:

(WebCore::JSConverter<IDLUnrestrictedDouble>::convert):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/JSCJSValue.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/js/JSDOMConvertNumbers.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-12-18  David Kilzer  <ddkilzer@apple.com>
+
+        clang-tidy: Use const reference for MediaTime parameter to prevent object copy
+        <https://webkit.org/b/192814>
+
+        Reviewed by Mark Lam.
+
+        * runtime/JSCJSValue.h:
+        (JSC::jsNumber):
+
 2018-12-18  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSCJSValue.h

@@ -552 +552 @@
 }
 
-ALWAYS_INLINE JSValue jsNumber(MediaTime t)
+ALWAYS_INLINE JSValue jsNumber(const MediaTime& t)
 {
     return jsNumber(t.toDouble());

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-12-18  David Kilzer  <ddkilzer@apple.com>
+
+        clang-tidy: Use const reference for MediaTime parameter to prevent object copy
+        <https://webkit.org/b/192814>
+
+        Reviewed by Mark Lam.
+
+        * bindings/js/JSDOMConvertNumbers.h:
+        (WebCore::JSConverter<IDLUnrestrictedDouble>::convert):
+
 2018-12-18  Justin Fan  <justin_fan@apple.com>
 

trunk/Source/WebCore/bindings/js/JSDOMConvertNumbers.h

@@ -390 +390 @@
 
     // Add overload for MediaTime.
-    static JSC::JSValue convert(MediaTime value)
+    static JSC::JSValue convert(const MediaTime& value)
     {
         return JSC::jsNumber(JSC::purifyNaN(value.toDouble()));