Changeset 239420 in webkit

Timestamp:

Dec 19, 2018 7:56:27 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Canvas: the recording auto-capture input shouldn't start focused
​https://bugs.webkit.org/show_bug.cgi?id=192454

Reviewed by Joseph Pecoraro.

• UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureCheckboxLabel):
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CanvasOverviewContentView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-12-19  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Canvas: the recording auto-capture input shouldn't start focused
+        https://bugs.webkit.org/show_bug.cgi?id=192454
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/CanvasOverviewContentView.js:
+        (WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureCheckboxLabel):
+        (WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged):
+
 2018-12-19  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js

@@ -210 +210 @@
         let label = frameCount === 1 ? WI.UIString("Record first %s frame") : WI.UIString("Record first %s frames");
 
+        let active = document.activeElement === this._recordingAutoCaptureFrameCountInputElement;
         let selectionStart = this._recordingAutoCaptureFrameCountInputElement.selectionStart;
         let selectionEnd = this._recordingAutoCaptureFrameCountInputElement.selectionEnd;
@@ -222 +223 @@
         this._recordingAutoCaptureNavigationItem.label = fragment;
 
-        this._recordingAutoCaptureFrameCountInputElement.selectionStart = selectionStart;
-        this._recordingAutoCaptureFrameCountInputElement.selectionEnd = selectionEnd;
-        this._recordingAutoCaptureFrameCountInputElement.direction = direction;
+        if (active) {
+            this._recordingAutoCaptureFrameCountInputElement.selectionStart = selectionStart;
+            this._recordingAutoCaptureFrameCountInputElement.selectionEnd = selectionEnd;
+            this._recordingAutoCaptureFrameCountInputElement.direction = direction;
+        }
     }
 
@@ -271 +274 @@
     _handleCanvasRecordingAutoCaptureFrameCountChanged(event)
     {
-        this._recordingAutoCaptureFrameCountInputElement.value = WI.settings.canvasRecordingAutoCaptureFrameCount.value;
+        // Only update the value if it is different to prevent mangling the selection.
+        if (parseInt(this._recordingAutoCaptureFrameCountInputElement.value) !== WI.settings.canvasRecordingAutoCaptureFrameCount.value)
+            this._recordingAutoCaptureFrameCountInputElement.value = WI.settings.canvasRecordingAutoCaptureFrameCount.value;
 
         this._updateRecordingAutoCaptureCheckboxLabel(WI.settings.canvasRecordingAutoCaptureFrameCount.value);