Changeset 239499 in webkit

Timestamp:

Dec 21, 2018 2:53:17 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

[GLIB] WebDriver: dbusConnectionClosedCallback can be called after SessionHost has been deleted
​https://bugs.webkit.org/show_bug.cgi?id=192976

Reviewed by Alejandro G. Castro.

Disconnect DBus connection signals using SessionHost as user data in SessionHost destructor.

• glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::~SessionHost):

Location:

trunk/Source/WebDriver

Files:

• ChangeLog (modified) (1 diff)
• glib/SessionHostGlib.cpp (modified) (1 diff)

trunk/Source/WebDriver/ChangeLog

@@ +1 @@
+2018-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GLIB] WebDriver: dbusConnectionClosedCallback can be called after SessionHost has been deleted
+        https://bugs.webkit.org/show_bug.cgi?id=192976
+
+        Reviewed by Alejandro G. Castro.
+
+        Disconnect DBus connection signals using SessionHost as user data in SessionHost destructor.
+
+        * glib/SessionHostGlib.cpp:
+        (WebDriver::SessionHost::~SessionHost):
+
 2018-12-20  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebDriver/glib/SessionHostGlib.cpp

@@ -42 +42 @@
 SessionHost::~SessionHost()
 {
+    if (m_dbusConnection)
+        g_signal_handlers_disconnect_matched(m_dbusConnection.get(), G_SIGNAL_MATCH_DATA, 0, 0, nullptr, nullptr, this);
     g_cancellable_cancel(m_cancellable.get());
     if (m_browser)