Changeset 239516 in webkit

Timestamp:

Dec 21, 2018 1:33:03 PM (5 years ago)

Author:

Justin Michaud

Message:

CSS variables don't work for colors in "border" property
​https://bugs.webkit.org/show_bug.cgi?id=192922

Reviewed by Simon Fraser.

Source/WebCore:

ParseColorFunction no longer consumes anything if the color was not valid.

Test: css-custom-properties-api/border-variable-parsing.html

• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseColorFunction):

LayoutTests:

• css-custom-properties-api/border-variable-parsing-expected.html: Added.
• css-custom-properties-api/border-variable-parsing.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css-custom-properties-api/border-variable-parsing-expected.html (added)
• LayoutTests/css-custom-properties-api/border-variable-parsing.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-12-21  Justin Michaud  <justin_michaud@apple.com>
+
+        CSS variables don't work for colors in "border" property
+        https://bugs.webkit.org/show_bug.cgi?id=192922
+
+        Reviewed by Simon Fraser.
+
+        * css-custom-properties-api/border-variable-parsing-expected.html: Added.
+        * css-custom-properties-api/border-variable-parsing.html: Added.
+
 2018-12-21  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-12-21  Justin Michaud  <justin_michaud@apple.com>
+
+        CSS variables don't work for colors in "border" property
+        https://bugs.webkit.org/show_bug.cgi?id=192922
+
+        Reviewed by Simon Fraser.
+
+        ParseColorFunction no longer consumes anything if the color was not valid.
+
+        Test: css-custom-properties-api/border-variable-parsing.html
+
+        * css/parser/CSSPropertyParserHelpers.cpp:
+        (WebCore::CSSPropertyParserHelpers::parseColorFunction):
+
 2018-12-21  Justin Fan  <justin_fan@apple.com>
 

trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

@@ -682 +682 @@
         return Color();
     }
-    range = colorRange;
+    if (color.isValid())
+        range = colorRange;
     return color;
 }