Changeset 239539 in webkit

Timestamp:

Dec 22, 2018 4:33:52 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

[HarfBuzz] Width not correctly reported as 0 for zero font size
​https://bugs.webkit.org/show_bug.cgi?id=192986

Reviewed by Michael Catanzaro.

Fixes test fast/text/font-size-zero.html

• platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Use empty advances for glyphs when the font
size is zero.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [HarfBuzz] Width not correctly reported as 0 for zero font size
+        https://bugs.webkit.org/show_bug.cgi?id=192986
+
+        Reviewed by Michael Catanzaro.
+
+        Fixes test fast/text/font-size-zero.html
+
+        * platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
+        (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Use empty advances for glyphs when the font
+        size is zero.
+
 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
 

trunk/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp

@@ -157 +157 @@
 
         uint16_t glyph = glyphInfos[i].codepoint;
-        if (m_font.isZeroWidthSpaceGlyph(glyph)) {
+        if (m_font.isZeroWidthSpaceGlyph(glyph) || !m_font.platformData().size()) {
             m_glyphs[i] = glyph;
             m_baseAdvances[i] = { };