Changeset 239579 in webkit

Timestamp:

Jan 2, 2019 3:41:56 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Fix resourcetimingbufferfull bubbles attribute
​https://bugs.webkit.org/show_bug.cgi?id=193087

Patch by Charles Vazac <​cvazac@gmail.com> on 2019-01-02
Reviewed by Chris Dumez.

Source/WebCore:

This change is covered by web-platform-tests [1].

[1] ​https://github.com/web-platform-tests/wpt/blob/master/resource-timing/buffer-full-when-populate-entries.html#L20

• page/Performance.cpp:

(WebCore::Performance::resourceTimingBufferFullTimerFired):

LayoutTests:

• http/wpt/resource-timing/rt-performance-extensions.js:

(promise_test):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/Performance.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-01-02  Charles Vazac  <cvazac@gmail.com>
+
+        Fix resourcetimingbufferfull bubbles attribute
+        https://bugs.webkit.org/show_bug.cgi?id=193087
+
+        Reviewed by Chris Dumez.
+
+        * http/wpt/resource-timing/rt-performance-extensions.js:
+        (promise_test):
+
 2019-01-02  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/http/wpt/resource-timing/rt-performance-extensions.js

@@ -103 +103 @@
         assert_equals(performance.getEntriesByType("resource").length, 1, "context global buffer should be full at 1 resource");
         assert_equals(bufferFullEvent.target, performance, "event should dispatch at the performance object");
-        assert_true(bufferFullEvent.bubbles, "event should bubble");
+        assert_false(bufferFullEvent.bubbles, "event should not bubble");
     });
 }, "resourcetimingbufferfull event properties", {timeout: 3000});

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-01-02  Charles Vazac  <cvazac@gmail.com>
+
+        Fix resourcetimingbufferfull bubbles attribute
+        https://bugs.webkit.org/show_bug.cgi?id=193087
+
+        Reviewed by Chris Dumez.
+
+        This change is covered by web-platform-tests [1].
+
+        [1] https://github.com/web-platform-tests/wpt/blob/master/resource-timing/buffer-full-when-populate-entries.html#L20
+
+        * page/Performance.cpp:
+        (WebCore::Performance::resourceTimingBufferFullTimerFired):
+
 2019-01-02  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/page/Performance.cpp

@@ -217 +217 @@
 
         m_resourceTimingBufferFullFlag = true;
-        dispatchEvent(Event::create(eventNames().resourcetimingbufferfullEvent, Event::CanBubble::Yes, Event::IsCancelable::No));
+        dispatchEvent(Event::create(eventNames().resourcetimingbufferfullEvent, Event::CanBubble::No, Event::IsCancelable::No));
 
         if (m_resourceTimingBufferFullFlag) {