Changeset 239613 in webkit

Timestamp:

Jan 4, 2019 9:18:17 AM (5 years ago)

Author:

Chris Fleizach

Message:

AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
​https://bugs.webkit.org/show_bug.cgi?id=193041
<rdar://problem/46954090>

Reviewed by Zalan Bujtas.

Source/WebCore:

• en.lproj/Localizable.strings:
• platform/cocoa/LocalizedStringsCocoa.mm:

(WebCore::AXHorizontalRuleDescriptionText):

LayoutTests:

• accessibility/mac/hr-element-expected.txt:
• platform/mac/accessibility/roles-exposed-expected.txt:
• platform/mac-wk2/accessibility/roles-exposed-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/mac/hr-element-expected.txt (modified) (4 diffs)
• LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt (modified) (1 diff)
• LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/en.lproj/Localizable.strings (modified) (1 diff)
• Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-01-04  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
+        https://bugs.webkit.org/show_bug.cgi?id=193041
+        <rdar://problem/46954090>
+
+        Reviewed by Zalan Bujtas.
+
+        * accessibility/mac/hr-element-expected.txt:
+        * platform/mac/accessibility/roles-exposed-expected.txt:
+        * platform/mac-wk2/accessibility/roles-exposed-expected.txt:
+
 2019-01-04  Frederic Wang  <fwang@igalia.com>
 

trunk/LayoutTests/accessibility/mac/hr-element-expected.txt

@@ -6 +6 @@
 hr1 role: AXRole: AXSplitter
 hr1 subrole: AXSubrole: AXContentSeparator
-hr1 roleDescription: AXRoleDescription: rule
+hr1 roleDescription: AXRoleDescription: separator
 hr1 description: AXDescription: 
 hr1 is value settable: false
@@ -14 +14 @@
 hr2 role: AXRole: AXSplitter
 hr2 subrole: AXSubrole: AXContentSeparator
-hr2 roleDescription: AXRoleDescription: rule
+hr2 roleDescription: AXRoleDescription: separator
 hr2 description: AXDescription: 
 hr2 is value settable: false
@@ -22 +22 @@
 hr3 role: AXRole: AXSplitter
 hr3 subrole: AXSubrole: AXContentSeparator
-hr3 roleDescription: AXRoleDescription: rule
+hr3 roleDescription: AXRoleDescription: separator
 hr3 description: AXDescription: RULER
 hr3 is value settable: false
@@ -30 +30 @@
 hr4 role: AXRole: AXSplitter
 hr4 subrole: AXSubrole: AXContentSeparator
-hr4 roleDescription: AXRoleDescription: rule
+hr4 roleDescription: AXRoleDescription: separator
 hr4 description: AXDescription: 
 hr4 is value settable: false

trunk/LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt

@@ -183 +183 @@
       AXRole: AXSplitter
       AXSubrole: AXContentSeparator
-      AXRoleDescription: rule
+      AXRoleDescription: separator
       
 i

trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt

@@ -183 +183 @@
       AXRole: AXSplitter
       AXSubrole: AXContentSeparator
-      AXRoleDescription: rule
+      AXRoleDescription: separator
       
 i

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-01-04  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
+        https://bugs.webkit.org/show_bug.cgi?id=193041
+        <rdar://problem/46954090>
+
+        Reviewed by Zalan Bujtas.
+
+        * en.lproj/Localizable.strings:
+        * platform/cocoa/LocalizedStringsCocoa.mm:
+        (WebCore::AXHorizontalRuleDescriptionText):
+
 2019-01-04  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/en.lproj/Localizable.strings

@@ -1251 +1251 @@
 
 /* accessibility role description for a horizontal rule [<hr>] */
-"rule" = "rule";
+"separator" = "separator";
 
 /* An ARIA accessibility group that contains a search feature of a website. */

trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm

@@ -231 +231 @@
 String AXHorizontalRuleDescriptionText()
 {
-    return WEB_UI_STRING("rule", "accessibility role description for a horizontal rule [<hr>]");
+    return WEB_UI_STRING("separator", "accessibility role description for a horizontal rule [<hr>]");
 }