Changeset 239919 in webkit


Ignore:
Timestamp:
Jan 14, 2019 2:32:03 AM (5 years ago)
Author:
commit-queue@webkit.org
Message:

[GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions
​https://bugs.webkit.org/show_bug.cgi?id=193239

Patch by Karl Leplat <​karl.leplat_ext@softathome.com> on 2019-01-14
Reviewed by Žan Doberšek.

Source/WebCore:

Test: compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::updateContentBuffers): Use enclosed dirty rect values
when invalidating the CoordinatedBackingStore areas.

LayoutTests:

  • compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html: Added.
  • platform/gtk/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
  • platform/gtk/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
  • platform/ios/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
  • platform/ios/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
  • platform/mac/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
  • platform/mac/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
  • platform/wpe/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
  • platform/wpe/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
Location:
trunk
Files:
11 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r239915 r239919  
     12019-01-14  Karl Leplat  <karl.leplat_ext@softathome.com>
     2
     3        [GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions
     4        https://bugs.webkit.org/show_bug.cgi?id=193239
     5
     6        Reviewed by Žan Doberšek.
     7
     8        * compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html: Added.
     9        * platform/gtk/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
     10        * platform/gtk/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
     11        * platform/ios/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
     12        * platform/ios/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
     13        * platform/mac/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
     14        * platform/mac/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
     15        * platform/wpe/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
     16        * platform/wpe/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
     17
    1182019-01-13  Carlos Garcia Campos  <cgarcia@igalia.com>
    219

  • trunk/Source/WebCore/ChangeLog

    r239915 r239919  
     12019-01-14  Karl Leplat  <karl.leplat_ext@softathome.com>
     2
     3        [GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions
     4        https://bugs.webkit.org/show_bug.cgi?id=193239
     5
     6        Reviewed by Žan Doberšek.
     7
     8        Test: compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html
     9
     10        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
     11        (WebCore::CoordinatedGraphicsLayer::updateContentBuffers): Use enclosed dirty rect values
     12        when invalidating the CoordinatedBackingStore areas.
     13
    1142019-01-13  Carlos Garcia Campos  <cgarcia@igalia.com>
    215

  • trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp

    r239461 r239919  
    889889    if (!m_needsDisplay.completeLayer) {
    890890        for (auto& rect : m_needsDisplay.rects)
    891             layerState.mainBackingStore->invalidate(IntRect { rect });
     891            layerState.mainBackingStore->invalidate(enclosingIntRect(rect));
    892892    } else
    893893        layerState.mainBackingStore->invalidate({ { }, IntSize { m_size } });
Note: See TracChangeset for help on using the changeset viewer.