Changeset 240205 in webkit


Ignore:
Timestamp:
Jan 19, 2019 3:31:43 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

AXSelected attribute on RadioButton should not be settable.
​https://bugs.webkit.org/show_bug.cgi?id=193371

Patch by Eric Liang <​ericliang@apple.com> on 2019-01-19
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/set-selected-editable.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canSetSelectedAttribute const):

LayoutTests:

This change make RadioButton AXSelected attribute no-settable. If this attribute is not writable, then the trackpad should work correctly.

  • accessibility/set-selected-editable-expected.txt: Added.
  • accessibility/set-selected-editable.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r240199 r240205  
     12019-01-19  Eric Liang  <ericliang@apple.com>
     2
     3        AXSelected attribute on RadioButton should not be settable.
     4        https://bugs.webkit.org/show_bug.cgi?id=193371
     5
     6        Reviewed by Chris Fleizach.
     7
     8        This change make RadioButton AXSelected attribute no-settable. If this attribute is not writable, then the trackpad should work correctly.
     9
     10        * accessibility/set-selected-editable-expected.txt: Added.
     11        * accessibility/set-selected-editable.html: Added.
     12
    1132019-01-18  Ryosuke Niwa  <rniwa@webkit.org>
    214

  • trunk/LayoutTests/platform/win/TestExpectations

    r240116 r240205  
    14561456webkit.org/b/140798 [ Release ] accessibility/aria-switch-text.html [ Skip ]
    14571457webkit.org/b/140798 [ Debug ] accessibility/aria-switch-text.html [ Skip ]
     1458webkit.org/b/193371 accessibility/set-selected-editable.html [ Skip ]
    14581459
    14591460# The following timeouts are caused by the same problem: [ Failure ]

  • trunk/Source/WebCore/ChangeLog

    r240201 r240205  
     12019-01-19  Eric Liang  <ericliang@apple.com>
     2
     3        AXSelected attribute on RadioButton should not be settable.
     4        https://bugs.webkit.org/show_bug.cgi?id=193371
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Test: accessibility/set-selected-editable.html
     9
     10        * accessibility/AccessibilityNodeObject.cpp:
     11        (WebCore::AccessibilityNodeObject::canSetSelectedAttribute const):
     12
    1132019-01-19  Antoine Quint  <graouts@apple.com>
    214

  • trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

    r232852 r240205  
    22332233    case AccessibilityRole::Cell:
    22342234    case AccessibilityRole::GridCell:
    2235     case AccessibilityRole::RadioButton:
    22362235    case AccessibilityRole::RowHeader:
    22372236    case AccessibilityRole::Row:
Note: See TracChangeset for help on using the changeset viewer.